[sbiscigl]

Description of changes:

Updates the crt-cpp version, homebrew updated openssl to point at version 4 Homebrew/homebrew-core#313581, and bumping to the latest version of crt fixes a compilation error.

/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:235:57: error: incomplete definition of type 'ASN1_IA5STRING' (aka 'struct asn1_string_st')
  235 |             unsigned char *san_str = san_name->d.dNSName->data;
      |                                      ~~~~~~~~~~~~~~~~~~~^
/opt/homebrew/include/openssl/types.h:57:16: note: forward declaration of 'struct asn1_string_st'
   57 | typedef struct asn1_string_st ASN1_INTEGER;
      |                ^
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:236:59: error: incomplete definition of type 'ASN1_IA5STRING' (aka 'struct asn1_string_st')
  236 |             const size_t san_str_len = san_name->d.dNSName->length;
      |                                        ~~~~~~~~~~~~~~~~~~~^
/opt/homebrew/include/openssl/types.h:57:16: note: forward declaration of 'struct asn1_string_st'
   57 | typedef struct asn1_string_st ASN1_INTEGER;
      |                ^
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:273:16: warning: initializing 'X509_NAME *' (aka 'struct X509_name_st *') with an expression of type 'const X509_NAME *' (aka 'const struct X509_name_st *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  273 |     X509_NAME *subject = X509_get_subject_name(x509_cert);
      |                ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:280:26: warning: initializing 'X509_NAME_ENTRY *' (aka 'struct X509_name_entry_st *') with an expression of type 'const X509_NAME_ENTRY *' (aka 'const struct X509_name_entry_st *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  280 |         X509_NAME_ENTRY *name_entry = X509_NAME_get_entry(subject, lastpos);
      |                          ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:285:22: warning: initializing 'ASN1_STRING *' (aka 'struct asn1_string_st *') with an expression of type 'const ASN1_STRING *' (aka 'const struct asn1_string_st *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  285 |         ASN1_STRING *asn1_str = X509_NAME_ENTRY_get_data(name_entry);
      |                      ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:733:40: error: call to undeclared function 'ASN1_STRING_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  733 |         unsigned char *internal_data = ASN1_STRING_data(asn1_str);
      |                                        ^
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:733:24: error: incompatible integer to pointer conversion initializing 'unsigned char *' with an expression of type 'int' [-Wint-conversion]
  733 |         unsigned char *internal_data = ASN1_STRING_data(asn1_str);
      |                        ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:805:25: warning: initializing 'X509_EXTENSION *' (aka 'struct X509_extension_st *') with an expression of type 'const X509_EXTENSION *' (aka 'const struct X509_extension_st *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  805 |         X509_EXTENSION *x509_ext = X509_get_ext(x509_cert, loc);
      |                         ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:813:22: warning: initializing 'ASN1_OBJECT *' (aka 'struct asn1_object_st *') with an expression of type 'const ASN1_OBJECT *' (aka 'const struct asn1_object_st *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  813 |         ASN1_OBJECT *asn1_obj = X509_EXTENSION_get_object(x509_ext);
      |                      ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:827:22: warning: assigning to 'ASN1_OCTET_STRING *' (aka 'struct asn1_string_st *') from 'const ASN1_OCTET_STRING *' (aka 'const struct asn1_string_st *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  827 |             asn1_str = X509_EXTENSION_get_data(x509_ext);
      |                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:840:48: error: call to undeclared function 'ASN1_STRING_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  840 |                 unsigned char *internal_data = ASN1_STRING_data(asn1_str);
      |                                                ^
/Users/sbiscigl/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/crypto/s2n_certificate.c:840:32: error: incompatible integer to pointer conversion initializing 'unsigned char *' with an expression of type 'int' [-Wint-conversion]
  840 |                 unsigned char *internal_data = ASN1_STRING_data(asn1_str);
      |                                ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings and 6 errors generated.

Check all that applies:

• Did a review by yourself.
• Added proper tests to cover this PR. (If tests are not applicable, explain.)
• Checked if this PR is a breaking (APIs have been changed) change.
• Checked if this PR will not introduce cross-platform inconsistent behavior.
• Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

• Linux
• Windows
• Android
• MacOS
• IOS
• Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.