Skip to content

[Test] In the proxy template, allowlist EPEL mirrors dynamically to prevent failures in test_build_image_no_internet. - #7561

Merged
gmarciani merged 3 commits into
aws:release-3.16from
gmarciani:wip/mgiacomo/3160/fix-build-no-internet-0813-1
Aug 14, 2026
Merged

[Test] In the proxy template, allowlist EPEL mirrors dynamically to prevent failures in test_build_image_no_internet.#7561
gmarciani merged 3 commits into
aws:release-3.16from
gmarciani:wip/mgiacomo/3160/fix-build-no-internet-0813-1

Conversation

@gmarciani

@gmarciani gmarciani commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description of changes

  1. In the proxy template used by tests, allowlist EPEL mirrors dynamically to prevent failures in test_build_image_no_internet. This is what a user would do to support the build-image in proxied environments. The proxy configuration is also validated by the proxy client, which verifies that every mirror is allowlisted.
    In this way the build instance can reach whichever EPEL mirror it is assigned.
  2. in test_build_image_no_internet , enable Nvidia installation for all OSs, except when DLAMI is used. In this way we can use this test to validate the nvidia installation.

Tests

  • SUCCESS manually deployed the proxy stack in personal account and validated that all the mirrors returned by the mirrorlist are now reachable.
  • SUCCESS (verified that NVIDIA was enabled on all tests but the one using DLAMI)
test-suites:
  createami:
    test_createami.py::test_build_image_no_internet:
      dimensions:
        # RHEL family (rhel8, rhel9) -> Red Hat Enterprise Linux reservation platform
        - regions: [{{ g4dn_2xlarge_CAPACITY_RESERVATION_2_INSTANCES_3_HOURS_NOPG_rhel9 }}]
          instances: ["g4dn.2xlarge"]
          oss: ["rhel8", "rhel9"]
        # Non-RHEL family (alinux2023, ubuntu2204, ubuntu2404, rocky8, rocky9) -> Linux/UNIX reservation platform
        - regions: [{{ g4dn_2xlarge_CAPACITY_RESERVATION_5_INSTANCES_3_HOURS_NOPG_ubuntu2404 }}]
          instances: ["g4dn.2xlarge"]
          oss: ["alinux2023", "ubuntu2204", "ubuntu2404", "rocky8", "rocky9"]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…revent failures in test_build_image_no_internet.

This is what a user would do to support the build-image in proxied environments.
The proxy configuration is also validated by the proxy client, which verifies
that every mirror is allowlisted.

In this way the build instance can reach whichever EPEL mirror it is assigned.
hanwen-cluster
hanwen-cluster previously approved these changes Aug 14, 2026
if os in ["ubuntu2204"]:
# Test Deep Learning AMIs
base_ami = retrieve_latest_ami(region, os, ami_type="remarkable", architecture=architecture)
enable_nvidia = False # Deep learning AMIs have Nvidia pre-installed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the reviewer.

This is the line that guarantees that NVIDIa is disabled when using DLAMI.

@gmarciani
gmarciani enabled auto-merge (rebase) August 14, 2026 20:04
@gmarciani
gmarciani disabled auto-merge August 14, 2026 20:04
@gmarciani
gmarciani enabled auto-merge (rebase) August 14, 2026 20:09
@gmarciani
gmarciani merged commit 6face33 into aws:release-3.16 Aug 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants