[Test] In the proxy template, allowlist EPEL mirrors dynamically to prevent failures in test_build_image_no_internet. - #7561
Merged
gmarciani merged 3 commits intoAug 14, 2026
Conversation
…revent failures in test_build_image_no_internet. This is what a user would do to support the build-image in proxied environments. The proxy configuration is also validated by the proxy client, which verifies that every mirror is allowlisted. In this way the build instance can reach whichever EPEL mirror it is assigned.
hanwen-cluster
previously approved these changes
Aug 14, 2026
…n on all OSS, but when DLAMI is used.
gmarciani
commented
Aug 14, 2026
| if os in ["ubuntu2204"]: | ||
| # Test Deep Learning AMIs | ||
| base_ami = retrieve_latest_ami(region, os, ami_type="remarkable", architecture=architecture) | ||
| enable_nvidia = False # Deep learning AMIs have Nvidia pre-installed |
Contributor
Author
There was a problem hiding this comment.
Note for the reviewer.
This is the line that guarantees that NVIDIa is disabled when using DLAMI.
hanwen-cluster
approved these changes
Aug 14, 2026
gmarciani
enabled auto-merge (rebase)
August 14, 2026 20:04
gmarciani
disabled auto-merge
August 14, 2026 20:04
gmarciani
enabled auto-merge (rebase)
August 14, 2026 20:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In this way the build instance can reach whichever EPEL mirror it is assigned.
test_build_image_no_internet, enable Nvidia installation for all OSs, except when DLAMI is used. In this way we can use this test to validate the nvidia installation.Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.