Fix cluster creation error when login nodes are used and cloudwatch is disabled - #7557
Open
hgreebe wants to merge 2 commits into
Open
Fix cluster creation error when login nodes are used and cloudwatch is disabled#7557hgreebe wants to merge 2 commits into
hgreebe wants to merge 2 commits into
Conversation
hgreebe
marked this pull request as ready for review
August 13, 2026 16:48
gmarciani
reviewed
Aug 13, 2026
| "dcv_enabled": "login_node" if self._pool.has_dcv_enabled else "false", | ||
| "dcv_port": self._pool.dcv.port if self._pool.dcv else "NONE", | ||
| "log_group_name": self._log_group.log_group_name, | ||
| "log_group_name": self._log_group.log_group_name if self._config.is_cw_logging_enabled else "NONE", |
Contributor
There was a problem hiding this comment.
Dont; we have a unit test we can extend to cover this change?
Contributor
|
This bug fix deserves an entry in the changelog for 3.16.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.