events: add Condition field to IAMPolicyStatement#636
Open
larrasket wants to merge 1 commit into
Open
Conversation
IAMPolicyStatement is the element of the policy a Lambda custom authorizer
returns (and of IoT policy documents), which follow the IAM JSON policy
grammar where Condition is a first-class element. The struct had no Condition
field, so any condition block was silently dropped on (un)marshal.
Add Condition as map[string]map[string]interface{} with omitempty. The
interface{} value type is required because a condition value may be a single
string or an array of strings; omitempty keeps condition-less statements
serializing unchanged (keeping the custom-authorizer response golden test green).
Fixes aws#458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IAMPolicyStatementis the element of the policy a Lambda custom authorizer returns (and of IoT policy documents), which follow the IAM JSON policy grammar where Condition is a first-class element. The struct had no Condition field, so any condition block was silently dropped on (un)marshal.Add Condition as
map[string]map[string]interface{}withomitempty. Theinterface{}value type is required because a condition value may be a single string or an array of strings;omitemptykeeps condition-less statements serializing unchanged (keeping the custom-authorizer response golden test green).Fixes #458