Adding feature to metrics#685
Merged
Merged
Conversation
rakshil14-2
marked this pull request as ready for review
May 20, 2026 21:47
xiazhvera
requested changes
Jun 10, 2026
rakshil14-2
force-pushed
the
metrics_support
branch
from
June 15, 2026 23:21
a5c680f to
2f6741e
Compare
xiazhvera
requested changes
Jul 16, 2026
|
|
||
| from awscrt.aws_iot_metrics import AWSIoTMetrics, IoTMetricsMetadata | ||
|
|
||
| _SDK_LIBRARY_NAME = "IoTDeviceSDK/Python" |
Contributor
There was a problem hiding this comment.
It seems unnecessary to have _SDK_LIBRARY_NAME as it is the same default value in AWSIoTMetrics.
|
|
||
| **cipher_pref** (:class:`awscrt.io.TlsCipherPref`): Cipher preference to use for TLS connection. Default is `TlsCipherPref.DEFAULT`. | ||
|
|
||
| **enable_metrics_collection** (`bool`): Whether to send the SDK version number in the CONNECT packet. |
Contributor
There was a problem hiding this comment.
The API has been introduced for several years. We don't plan to break the API so far.
|
|
||
| **cipher_pref** (:class:`awscrt.io.TlsCipherPref`): Cipher preference to use for TLS connection. Default is `TlsCipherPref.DEFAULT`. | ||
|
|
||
| **enable_metrics_collection** (`bool`): Whether to send the SDK version number in the CONNECT packet. |
Contributor
There was a problem hiding this comment.
The API has been introduced for several years. We don't plan to break the API so far.
xiazhvera
reviewed
Jul 16, 2026
|
|
||
| class TestBuildSdkMetrics(unittest.TestCase): | ||
|
|
||
| def test_library_name(self): |
Contributor
There was a problem hiding this comment.
Could we keep the test, just verify the default library name was setup properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
enable_metrics_collection.AWS_IoT_Metricssupport for SDK layeriot-device-sdkversion to sdk metrics.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.