fix: trigger failover on read-only connection errors in strict-writer mode#673
Open
sudosubin wants to merge 1 commit into
Open
fix: trigger failover on read-only connection errors in strict-writer mode#673sudosubin wants to merge 1 commit into
sudosubin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trigger failover on read-only connection errors in strict-writer mode, matching the JDBC and Python wrappers.
Description
After an Aurora writer failover, a pooled connection may still point at the former writer, now demoted to a reader. Writes on it return a read-only error (PostgreSQL SQLSTATE 25006, MySQL errno 1290/1836) rather than a network error. Since
shouldErrorTriggerClientSwitchonly checksisNetworkError, failover is never triggered and the connection stays pinned to the old writer. The JDBC and Python wrappers already treat this as a failover trigger in strict-writer mode.This adds
isReadOnlyConnectionErrortoErrorHandler(PG: SQLSTATE 25006; MySQL: errno 1290/1836), delegated throughPluginServicelikeisNetworkError, and makesFailover2Plugin/FailoverPlugintrigger failover on it in strict-writer mode only (reader-or-writer mode is unchanged). Unit tests included.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.