Add UpdateFeature (PATCH) operation with updatable field - #56
Open
bpescato-amazon wants to merge 1 commit into
Open
Add UpdateFeature (PATCH) operation with updatable field#56bpescato-amazon wants to merge 1 commit into
bpescato-amazon wants to merge 1 commit into
Conversation
- Add PATCH operation on Feature resource (UpdateFeature) following the same pattern as UpdateConnection: full Feature body + optional updateMask - Add read-only 'updatable' boolean field to Feature schema (optional, defaults to false), allowing providers to declare update support - Document 405 METHOD_NOT_ALLOWED response for non-updatable features - Update FeatureType enum description to document updatability per type (FEATURE_TYPE_L3_BASE: NOT updatable)
dkarwowski
approved these changes
Jul 31, 2026
| The type of feature. | ||
|
|
||
| Each feature type documents whether it supports updates via UpdateFeature: | ||
| - FEATURE_TYPE_L3_BASE: NOT updatable. Primary feature used to connect |
Collaborator
There was a problem hiding this comment.
I would argue we choose one of the boolean, or this documentation. If we're saying L3_BASE is never updateable (which I do agree with), then I'd rather just document the 405 response on PATCH if it's used on a feature type that doesn't support updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.