Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasePersistenceLayerkeeps the key prefix as mutable state and everyIdempotencyHandlerconstruction reconfigures it, so an operation that awaited a nested idempotent call completed under the nested operation's prefix and overwrote its record. Operations now capture the prefix the store resolved for them and re-apply it immediately before each persistence call.configure()also resets the prefix to its base when neitherkeyPrefixnorfunctionNameis given, so an operation without a prefix no longer inherits a sibling's.Changes
idempotencyKeyPrefixto the base value inconfigure()when no prefix or function name is suppliedIdempotencyHandlerand restore it on the store before save, get, update, and delete calls#keyPrefixfieldconfigure()reset, and one pinning that the key is hashed before the first awaitIssue number: closes #5707
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.