Ignore non-validators when receiving quorum rounds - #456
Conversation
| return nil | ||
| } | ||
|
|
||
| validators := n.highestEpochCollector.latestValidatorSetRetriever.Validators() |
There was a problem hiding this comment.
i think we'd rather have this check inside epochDigestCounter.
Simplex/nonvalidator/epochs.go
Line 163 in 55853f3
What's the issue with a non-validator sending us a valid quorum round?
There was a problem hiding this comment.
why would the non-validator do this? We only replicate from validators both in snowman and simplex.
There was a problem hiding this comment.
sure, but i feel like this is a weird place to do this. Why not put it at the top level of handleReplicationResponse or even do something like we did with handleMessage in epoch.go where we blocked/allowed certain messages from non-validators.
Also, if we receive 100 quorum rounds we will run validators.Contains on all 100 of them which is unnecessary since from never changes.
There was a problem hiding this comment.
Why not put it at the top level of handleReplicationResponse or even do something like we did with handleMessage in epoch.go where we blocked/allowed certain messages from non-validators.
Moved it to handleReplicationResponse.
Also, if we receive 100 quorum rounds we will run validators.Contains on all 100 of them which is unnecessary since from never changes.
Yeah, agreed.
23c922b to
b97f2af
Compare
This commit makes non-validators ignore quorum rounds sent from non-validators. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
4f48874 to
29f49f3
Compare
2 participants
This commit makes non-validators ignore quorum rounds sent from non-validators.