Fix retention term - #453
Open
yacovm wants to merge 2 commits into
Open
Conversation
yacovm
marked this pull request as draft
July 22, 2026 23:12
yacovm
marked this pull request as ready for review
July 23, 2026 14:19
When a finalization is written to the WAL, the garbage collecting WAL invokes RetentionTerm() as part of its Append() operation. However, the current implementation returned an error in case it was a finalization. This commit fixes this by adding the finalization option to the RetentionTerm function. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
samliok
reviewed
Jul 28, 2026
| switch recordType { | ||
| case BlockRecordType: | ||
| return BlockRecordRetentionTerm(entry) | ||
| case NotarizationRecordType: |
Collaborator
There was a problem hiding this comment.
why dont we just have one branch for all QuorumRecordRetentionTerm(entry) calls?
Collaborator
Author
There was a problem hiding this comment.
Because once we merge the canoto PR we won't have one branch: https://github.com/ava-labs/Simplex/pull/435/changes#diff-1393209f6936423d26252ab8fbe095edfcb077b497d3913b439e139dd17e5d49R369-R377
| type noopComm struct{} | ||
|
|
||
| func (noopComm) Broadcast(*common.Message) {} | ||
| func (noopComm) Send(*common.Message, common.NodeID) {} |
Collaborator
There was a problem hiding this comment.
i think we have testuitl.NoopComm already
| func (noopComm) Broadcast(*common.Message) {} | ||
| func (noopComm) Send(*common.Message, common.NodeID) {} | ||
|
|
||
| func TestInstanceOutOfOrderFinalizationPersistedToWAL(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
aren't we just testing the garbage collection WAL? Can't we replicate this behavior in a more simple manner without the instance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a finalization is written to the WAL, the garbage collecting WAL invokes RetentionTerm()
as part of its Append() operation.
However, the current implementation returned an error in case it was a finalization.
This commit fixes this by adding the finalization option to the RetentionTerm function.