fix: serve docs assets from the same origin as pages#570
Open
ivanauth wants to merge 1 commit into
Open
Conversation
The production assetPrefix pointed at docs-authzed.vercel.app, so pages loaded from authzed.com pulled their assets from a second domain, which breaks for users behind restrictive firewalls. The authzed.com rewrite already proxies everything under /docs, including /docs/_next/static assets, so the prefix is unnecessary: relative asset URLs resolve same-origin through the existing rewrite. With no cross-origin asset domain left, the crossOrigin setting added for the CDN domain is no longer needed either.
Contributor
|
Preview deployment skipped — @ivanauth does not have write access to this repository. A maintainer can trigger a preview deployment by re-running this workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #478.
Docs pages are served from
authzed.com/docsbut their assets (JS/CSS/fonts) were loaded from a second domain (docs-authzed.vercel.app) viaassetPrefix, which breaks for users behind restrictive firewalls.Removes the production
assetPrefix(and thecrossOrigin: "anonymous"that only existed to support the cross-origin CDN).