chore: sync chart version with the Authorizer version - #16
Merged
Conversation
`helm install --version 2.4.1` now gets Authorizer 2.4.1. There is no mapping table to consult, which is the whole point. The two drifted through the 2.4.x line because chart-only fixes patch-bumped the chart independently: the chart reached 2.4.5 while the app was still 2.4.0, and by the time Authorizer 2.4.1 shipped the chart version 2.4.1 had already been consumed — so the release landed as chart 2.4.6/app 2.4.1. Re-synced at 2.4.1, and the rule that keeps it synced is written down in Chart.yaml and the README: a chart-only fix does not bump the version on its own, it rides the next Authorizer release. release.sh now sets both fields to the release version instead of patch-bumping the chart. Removed the four chart-only artifacts that caused the drift (2.4.3, 2.4.4, 2.4.5, 2.4.6) and republished their template fixes as 2.4.1, so every 2.4.x chart maps 1:1 to an Authorizer release. index.yaml is regenerated from charts/ (59 entries, 59 files). Chart 2.4.0 is left as the only chart for app 2.4.0 and therefore lacks those later template fixes — acceptable because 2.4.0 is the release both published advisories affect, and everyone on it should move to 2.4.1. Safe to do now because the chart has no live users. Claude-Session: https://claude.ai/code/session_016dbRdiyrapnT7J3tAyZhdR
✅ Deploy Preview for authorizer-helm-chart ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
helm install --version 2.4.1get Authorizer 2.4.1. No mapping table.Why they drifted
Chart-only fixes patch-bumped the chart independently of the app:
By the time Authorizer 2.4.1 shipped, chart version
2.4.1was already consumed by a chart-only fix, so the release had to land as chart 2.4.6. That is the failure mode, not just cosmetic drift.Note the 1.x line was synced (chart 1.3.8 = app 1.3.8, 1.4.0 = 1.4.0); this is a regression introduced in 2.x, not a new policy.
Change
Chart.yaml:version: 2.4.1to matchappVersion: "2.4.1".Chart.yamland the README: a chart-only fix does not bump the version on its own — it rides the next Authorizer release, or you cut an Authorizer patch release to carry it. Without that rule the drift simply restarts.release.shnow sets both fields to the release version instead of patch-bumping the chart. (It also had a silently-broken README sync — thesedstopped matching when the README was reworded, so the README advertised a stale appVersion for the whole 2.4.x line. Fixed, and it now fails loudly instead of skipping.)Removed artifacts
Deleted
2.4.3,2.4.4,2.4.5,2.4.6and republished their template fixes as2.4.1, so every 2.4.x chart maps 1:1 to an Authorizer release.index.yamlis regenerated fromcharts/— 59 entries, 59 files, verified.Consequence worth stating: chart
2.4.0is now the only chart for app 2.4.0 and therefore lacks the later template fixes (b64encnumeric values, theredirect_urisguard). That is acceptable because 2.4.0 is the release both published advisories affect — anyone on it should move to 2.4.1 regardless. The new 2.4.1 package carries all of those fixes (verified: 4redirect_urisreferences in the rendered template).Safe to do now because the chart has no live users.
helm lintpasses and the rendered image resolves toquay.io/authorizer/authorizer:2.4.1.https://claude.ai/code/session_016dbRdiyrapnT7J3tAyZhdR