Skip to content

Fix Date claims before the Unix epoch rounding toward zero #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hossam1244 wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −1
Open

Fix Date claims before the Unix epoch rounding toward zero #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/src/main/java/com/auth0/jwt/impl/ClaimsSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ private static long instantToSeconds(Instant instant) {
}

private static long dateToSeconds(Date date) {
return date.getTime() / 1000;
// Floor (not truncate) so dates before the Unix epoch round toward
// negative infinity, matching Instant#getEpochSecond. (GH-806)
return Math.floorDiv(date.getTime(), 1000L);
}
}
30 changes: 30 additions & 0 deletions lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,36 @@ public void shouldAddExpiresAtInstant() {
assertThat(TokenUtils.splitToken(signed)[1], is("eyJleHAiOjE0Nzc1OTJ9"));
}

@Test
public void shouldAddExpiresAtBeforeEpochConsistentlyWithInstant() {
// Dates before the Unix epoch must floor to the previous second,
// matching the Instant serialization (GH-806).
Date date = new Date(-500);
Instant instant = date.toInstant();

String signedDate = JWTCreator.init()
.withExpiresAt(date)
.sign(Algorithm.HMAC256("secret"));
String signedInstant = JWTCreator.init()
.withExpiresAt(instant)
.sign(Algorithm.HMAC256("secret"));

assertThat(signedDate, is(notNullValue()));
assertThat(signedInstant, is(notNullValue()));
assertThat(TokenUtils.splitToken(signedDate)[1], is("eyJleHAiOi0xfQ"));
assertThat(TokenUtils.splitToken(signedDate)[1], is(TokenUtils.splitToken(signedInstant)[1]));
}

@Test
public void shouldAddNotBeforeBeforeEpoch() {
String signed = JWTCreator.init()
.withNotBefore(new Date(-500))
.sign(Algorithm.HMAC256("secret"));

assertThat(signed, is(notNullValue()));
assertThat(TokenUtils.splitToken(signed)[1], is("eyJuYmYiOi0xfQ"));
}

@Test
public void shouldAddNotBefore() {
String signed = JWTCreator.init()
Expand Down