TCP improvements#194
Merged
Merged
Conversation
ZipFile
commented
Jul 14, 2026
Contributor
- Deduplicate framing parsing:
-
- It was done 4 times in 4 different places. Not good.
-
- New implementation tries to avoid excess memory allocations. Could be done better, but that would require major architectural changes.
-
- Abstractions for the god of abstractions.
-
- Since framing parser logic is separate now, it makes it possible to reuse it for e.g. OSC over SlipSerial #48/No way to take raw OSC packet and convert it to OscMessage object #65 or any other streaming protocols.
- Remove redundant logging, since this info in one way or another is logged by Python itself (see changes in examples).
- Update TCP examples to utilize request-response feature. There already was some logic to print responses, but nothing were sent to the server that would trigger actual response.
ZipFile
force-pushed
the
tcp-cleanup
branch
2 times, most recently
from
July 14, 2026 15:29
f49f67f to
3ef820c
Compare
Owner
|
Thanks for the many fixes, just minor ruff fixes and this can be merged. |
Contributor
Author
|
Done. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.