Skip to content

TCP improvements#194

Merged
attwad merged 1 commit into
attwad:mainfrom
ZipFile:tcp-cleanup
Jul 16, 2026
Merged

TCP improvements#194
attwad merged 1 commit into
attwad:mainfrom
ZipFile:tcp-cleanup

Conversation

@ZipFile

@ZipFile ZipFile commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
  • Deduplicate framing parsing:
    • It was done 4 times in 4 different places. Not good.
    • New implementation tries to avoid excess memory allocations. Could be done better, but that would require major architectural changes.
    • Abstractions for the god of abstractions.
  • Remove redundant logging, since this info in one way or another is logged by Python itself (see changes in examples).
  • Update TCP examples to utilize request-response feature. There already was some logic to print responses, but nothing were sent to the server that would trigger actual response.

@ZipFile
ZipFile force-pushed the tcp-cleanup branch 2 times, most recently from f49f67f to 3ef820c Compare July 14, 2026 15:29
@attwad

attwad commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Thanks for the many fixes, just minor ruff fixes and this can be merged.

@ZipFile

ZipFile commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Done.

@attwad
attwad merged commit 955c5ff into attwad:main Jul 16, 2026
5 checks passed
@attwad

attwad commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Thanks!

@ZipFile
ZipFile deleted the tcp-cleanup branch July 16, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants