fix: raise mobile sidebar touch targets to 44px minimum - #195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every primary navigation link, database disclosure button, drawer close button, and the theme toggle in the mobile sidebar now render at a 44x44px minimum, matching the 44px hamburger that opens the drawer (previously these controls were 40px, or had no explicit minimum in the theme toggle's case).
Changes
navLinkClasses(covers all primary and nested links):min-h-[40px]→min-h-[44px]min-h-[40px]→min-h-[44px]min-h-[40px] min-w-[40px]→min-h-[44px] min-w-[44px]min-h-[44px]so all drawer controls share one consistent target-size ruleIcon/label layout and the scrollable nav region are unchanged; the scrollable region keeps everything reachable with many databases.
Test plan
npm run build -w shared && npm run build -w clientpasses (tsc -b + vite build)Closes #177