This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fixes space after colon highliting - #32
Open
petems wants to merge 1 commit into
Open
Conversation
| '2': | ||
| 'name': 'entity.name.section.puppet' | ||
| 'match': '^\\s*(\\w+)\\s*{\\s*([\'"].+[\'"]):' | ||
| 'match': '^\\s*(\\w+)\\s*{\\s*([\'"].+[\'"]\\s*):' |
Contributor
There was a problem hiding this comment.
The spaces should not be captured as entity.name.section.puppet.
petems
force-pushed
the
fix_extra_space_highlight
branch
from
March 12, 2016 21:03
4b4effc to
0b81deb
Compare
petems
force-pushed
the
fix_extra_space_highlight
branch
2 times, most recently
from
March 15, 2016 14:58
45c0368 to
cefc69d
Compare
Contributor
|
It looks like this has diverged from the |
petems
force-pushed
the
fix_extra_space_highlight
branch
from
April 8, 2016 15:09
cefc69d to
1794d1f
Compare
| 'match': '^\\s*(\\w+)\\s*{\\s*([\'"].+[\'"]):' | ||
| '3': | ||
| 'name': 'entity.name.section.puppet' | ||
| 'match': '^\\s*(\\w+)\\s*{\\s*([\'"].+[\'"]*)(\\s*:)' |
Contributor
There was a problem hiding this comment.
Why are we matching \\s*: as entity.name.section.puppet?
Contributor
|
@petems are you interested in still working on this PR? If you aren't, I will try to find some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
