Skip to content

Fix excessive whitespace on newsletter page - #5658

Open
Harit2207 wants to merge 2 commits into
asyncapi:masterfrom
Harit2207:master
Open

Fix excessive whitespace on newsletter page#5658
Harit2207 wants to merge 2 commits into
asyncapi:masterfrom
Harit2207:master

Conversation

@Harit2207

@Harit2207 Harit2207 commented Jul 27, 2026

Copy link
Copy Markdown

Description

Reduced excessive whitespace on the newsletter page.
Updated the layout styling in components/layout/Layout.tsx to improve spacing and visual balance.
Improved the overall user experience by making the newsletter section more compact and consistent with the rest of the page.

Related issue(s)

Fixes #5627

Summary by CodeRabbit

  • Bug Fixes
    • Improved layout sizing on standard routes so the main content fills available vertical space more consistently.
    • Adjusted the stacking order of an open filter dropdown so it layers appropriately over surrounding page content.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e6cf755
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/6a68dede7b5b2c000828f5d3
😎 Deploy Preview https://deploy-preview-5658--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 906d9187-191f-4c72-98a6-b4487a332918

📥 Commits

Reviewing files that changed from the base of the PR and between d9212b0 and e6cf755.

📒 Files selected for processing (1)
  • components/navigation/FilterDropdown.tsx

📝 Walkthrough

Walkthrough

The fallback layout wrapper now uses flex-1 instead of min-h-screen, and the open filter dropdown options container now uses z-40 instead of z-50.

Changes

Layout and navigation styling

Layer / File(s) Summary
Fallback wrapper sizing
components/layout/Layout.tsx
The fallback wrapper changes from min-h-screen to flex-1 while continuing to render children.
Filter dropdown layering
components/navigation/FilterDropdown.tsx
The open options container changes from z-50 to z-40.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: derberg, princerajpoot20, akshatnema, sambhavgupta0705, asyncapi-bot-eve

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The FilterDropdown z-index change appears unrelated to the newsletter whitespace issue. Move the dropdown stacking change to a separate PR or explain why it is required for the whitespace fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: reducing excessive whitespace on the newsletter page.
Linked Issues check ✅ Passed The Layout.tsx change addresses the reported whitespace issue on the newsletter page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asyncapi-bot

asyncapi-bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5658--asyncapi-website.netlify.app/

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

Too much whitespace in newsletter page

2 participants