Allow per-call CCD extension overrides - #960
Open
nomad3 wants to merge 3 commits into
Open
Conversation
nomad3
added a commit
to nomad3/ccdproc
that referenced
this pull request
Jul 19, 2026
Signed-off-by: Simon Aguilera <saguilera1608@gmail.com>
Fixes astropy#817 Signed-off-by: Simon Aguilera <saguilera1608@gmail.com>
Signed-off-by: Simon Aguilera <saguilera1608@gmail.com>
Signed-off-by: Simon Aguilera <saguilera1608@gmail.com>
nomad3
force-pushed
the
fix-817-ccd-extension-override
branch
from
July 27, 2026 04:21
df72651 to
81fe53d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
+ Coverage 96.63% 96.64% +0.01%
==========================================
Files 8 8
Lines 1575 1581 +6
==========================================
+ Hits 1522 1528 +6
Misses 53 53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nomad3
marked this pull request as ready for review
July 27, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extargument toImageFileCollection.ccds()for selecting a FITS data extension per callccd_kwargs["hdu"], avoid mutating caller dictionaries, and reject contradictory selectors explicitly(name, version), and zero-valued selectors with offline multi-extension FITS regressionsccds()docstring builds cleanly under Sphinx warnings-as-errorsCompatibility boundary:
extis now reserved as the per-call selector; code that needs to filter anEXTheader keyword should filter the collection before callingccds().Fixes #817
Validation
main: 7 failedpython -m pytest ccdproc/tests/test_image_collection.py -q— 85 passedextis a parameter and every description line is indented beneath itgit diff --check, andgit show --checkAI assistance disclosure
OpenAI Codex was used for repository inspection, test design, implementation, CI diagnosis, and automated review. The contributor has completed the final review and takes responsibility for the contribution's correctness and maintenance.
Checklist
AUTHORS.rstfile? (Present on current main through merged Exclude masked weights from average combinations #952.)[skip ci]? (Not a documentation-only change.)For new functionality:
CHANGES.rst?Fixes #817?extparameter.)