Skip to content

perf: avoid substring allocation in getBinaryOperator for C# && and || #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askpt merged 2 commits into from
Jul 27, 2026
Merged

perf: avoid substring allocation in getBinaryOperator for C# && and || #480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8b0f17
perf: avoid substring allocation in getBinaryOperator for C# && and ||
github-actions[bot] Jul 27, 2026
3d2e846
Merge branch 'main' into repo-assist/perf-csharp-binop-O1-20260727-9f…
askpt Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/metricsAnalyzer/languages/csharpAnalyzer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,15 +756,14 @@ export class CSharpMetricsAnalyzer {
* @returns The operator string or null if not found
*/
private getBinaryOperator(node: Parser.SyntaxNode): string | null {
// binary_expression structure: [left, operator, right] — operator always at index 1
// binary_expression structure: [left, operator, right] — operator always at index 1.
// In tree-sitter-c-sharp, anonymous operator tokens use their literal text as their node
// type (e.g. type === "&&"), so reading `.type` avoids a sourceText.substring allocation.
const operatorNode = node.child(1);
if (!operatorNode) { return null; }
const type = operatorNode.type;
if (type === "&&" || type === "||" || type === "binary_operator") {
return this.sourceText.substring(
operatorNode.startIndex,
operatorNode.endIndex
);
if (type === "&&" || type === "||") {
return type;
}
return null;
}
Expand Down