Skip to content

destroy-cumulus: Add resources for consolidated cumulus - #74

Merged
reweeden merged 10 commits into
mainfrom
rew/decumulus-cnsld-resources
Jul 14, 2026
Merged

destroy-cumulus: Add resources for consolidated cumulus#74
reweeden merged 10 commits into
mainfrom
rew/decumulus-cnsld-resources

Conversation

@reweeden

@reweeden reweeden commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@reweeden
reweeden force-pushed the rew/decumulus-cnsld-resources branch 3 times, most recently from 84987a9 to fcd4d50 Compare July 6, 2026 20:03
@reweeden
reweeden force-pushed the rew/decumulus-cnsld-resources branch 2 times, most recently from 6f9b3c3 to 8427a3a Compare July 6, 2026 20:09
@reweeden
reweeden marked this pull request as ready for review July 6, 2026 20:17
@reweeden
reweeden force-pushed the rew/decumulus-cnsld-resources branch from 8427a3a to 03636ba Compare July 6, 2026 21:41
@reweeden
reweeden force-pushed the rew/decumulus-cnsld-resources branch from 03636ba to 1d08fd0 Compare July 6, 2026 23:11

def delete(self, get_client):
client = get_client("ec2")
# NOTE: Could actually do a bulk delete here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a todo? If is there a reason not to?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no bulk delete mechanism built into the tool at the moment, and because of how the prompt selection works where you can select to delete individual resources it would require a bit of refactoring to actually implement that. It's not something that's necessary to add, so I'm leaving it as a note rather than a todo. If enough of them show up maybe it could be worth looking at that later, but I doubt it. There is like 1 other resource that has this same comment already I think.

@reweeden
reweeden merged commit f12b2eb into main Jul 14, 2026
6 checks passed
@reweeden
reweeden deleted the rew/decumulus-cnsld-resources branch July 14, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants