destroy-cumulus: Add resources for consolidated cumulus - #74
Merged
Conversation
reweeden
force-pushed
the
rew/decumulus-cnsld-resources
branch
3 times, most recently
from
July 6, 2026 20:03
84987a9 to
fcd4d50
Compare
reweeden
force-pushed
the
rew/decumulus-cnsld-resources
branch
2 times, most recently
from
July 6, 2026 20:09
6f9b3c3 to
8427a3a
Compare
reweeden
marked this pull request as ready for review
July 6, 2026 20:17
reweeden
force-pushed
the
rew/decumulus-cnsld-resources
branch
from
July 6, 2026 21:41
8427a3a to
03636ba
Compare
reweeden
force-pushed
the
rew/decumulus-cnsld-resources
branch
from
July 6, 2026 23:11
03636ba to
1d08fd0
Compare
Cameronsplaze
approved these changes
Jul 13, 2026
|
|
||
| def delete(self, get_client): | ||
| client = get_client("ec2") | ||
| # NOTE: Could actually do a bulk delete here |
Member
There was a problem hiding this comment.
This feels like a todo? If is there a reason not to?
Contributor
Author
There was a problem hiding this comment.
There is no bulk delete mechanism built into the tool at the moment, and because of how the prompt selection works where you can select to delete individual resources it would require a bit of refactoring to actually implement that. It's not something that's necessary to add, so I'm leaving it as a note rather than a todo. If enough of them show up maybe it could be worth looking at that later, but I doubt it. There is like 1 other resource that has this same comment already I think.
gjclark
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
I have: