Repository navigation
docs: recommend Node 26 while keeping Lambda on Node 24 - #156
Merged
Merged
Conversation
leoxlin
approved these changes
Nov 12, 2026
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
README.mdrecommended older Node images and described Node 26 as "preview; not LTS". That guidance led articulate/todonnell-testing#132 to selectarticulate/node:24, while the requested recommendation is now Node 26 for services and Node 24 for Lambda.Solution
Updated the Tags section to recommend
articulate/node:26for services and retainarticulate/node:24-lambdafor Lambda, with a note and matching 🌟 markers. Removed the Node 26 lifecycle label without adding lifecycle claims, and noted that no Node 26 Lambda image exists yet. OnlyREADME.mdchanged; articulate/todonnell-testing and PR #132 were not modified. The reviewer should confirm the decision to remove the recommendation markers fromarticulate/node:24andarticulate/node:22.Task brief and coder report
Task brief
Update the README in articulate/docker-node to officially recommend Node 26 while keeping the Lambda recommendation at Node 24. The previous upgrade PR articulate/todonnell-testing#132 selected articulate/node:24 because the docker-node README recommended 24 and described 26 as a non-LTS preview. That characterization was challenged, and requester U06RF6ESEHJ now explicitly requests the documentation change.
Check applicable internal knowledge conventions before editing and inspect the current README. Update the Node recommendations consistently throughout the README, preserving the Lambda recommendation at Node 24. Avoid introducing unsupported lifecycle claims, and address existing lifecycle wording as needed to make the recommendation consistent without asserting unverified status. This request supersedes the earlier cancelled delegation concerning todonnell-testing: do not modify that repository or PR #132.
Verify the documentation diff and open a PR in articulate/docker-node. Return a concise outcome with the PR URL, verification performed, any blockers, and sources read.
Source: https://articulate.slack.com/archives/C0C38QZ264B/p1794506584719799?thread_ts=1794506584.719799&cid=C0C38QZ264B . Direct requester instruction: "update the docker-node repo README to officially recommend node 26. Keep lambda at node 24 for now".
Coder report
The README now recommends
articulate/node:26for services andarticulate/node:24-lambdafor Lambda. The 🌟 marker sits on those two tags, and a short note above the list says the same thing in words.What changed in the Tags section:
articulate/node:24andarticulate/node:22and ontoarticulate/node:26. Leaving those stars in place would have kept three general recommendations alongside 26, so this is the one judgment call in the diff.26/contains onlybase/, while20/,22/and24/each have alambda/image.I did not touch articulate/todonnell-testing or PR #132.
Verification:
git diff: onlyREADME.mdchanged, and only the Tags section.grepfor LTS, preview, EOL, maintenance and "current" in the edited README found nothing.markdownlint-cli2reported 0 issues, the same as the unedited README.Blockers: None. No internal knowledge base was available here, so I checked only the conventions in the repo itself.
Sources read:
README.md.github/PULL_REQUEST_TEMPLATE.md.github/CODEOWNERS.github/workflows/lint.yml20/,22/,24/and26/directory layouts, plus26/base/Dockerfile,24/base/Dockerfileand24/lambda/Dockerfile(their tag comments and base images)Source: a direct request
Requested by Leo Lin (Slack
@Leo Lin).Opened by catzo.
Model:
anthropic/claude-opus-5-5Reasoning:
high