Skip to content

docs: recommend Node 26 while keeping Lambda on Node 24 - #156

Merged
leoxlin merged 1 commit into
mainfrom
chore/b680c3ac-recommend-node-26
Nov 12, 2026
Merged

leoxlin merged 1 commit into
mainfrom
chore/b680c3ac-recommend-node-26

Conversation

@catzo-agent

@catzo-agent catzo-agent Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Problem

README.md recommended older Node images and described Node 26 as "preview; not LTS". That guidance led articulate/todonnell-testing#132 to select articulate/node:24, while the requested recommendation is now Node 26 for services and Node 24 for Lambda.

Solution

Updated the Tags section to recommend articulate/node:26 for services and retain articulate/node:24-lambda for Lambda, with a note and matching 🌟 markers. Removed the Node 26 lifecycle label without adding lifecycle claims, and noted that no Node 26 Lambda image exists yet. Only README.md changed; articulate/todonnell-testing and PR #132 were not modified. The reviewer should confirm the decision to remove the recommendation markers from articulate/node:24 and articulate/node:22.

Task brief and coder report

Task brief

Update the README in articulate/docker-node to officially recommend Node 26 while keeping the Lambda recommendation at Node 24. The previous upgrade PR articulate/todonnell-testing#132 selected articulate/node:24 because the docker-node README recommended 24 and described 26 as a non-LTS preview. That characterization was challenged, and requester U06RF6ESEHJ now explicitly requests the documentation change.

Check applicable internal knowledge conventions before editing and inspect the current README. Update the Node recommendations consistently throughout the README, preserving the Lambda recommendation at Node 24. Avoid introducing unsupported lifecycle claims, and address existing lifecycle wording as needed to make the recommendation consistent without asserting unverified status. This request supersedes the earlier cancelled delegation concerning todonnell-testing: do not modify that repository or PR #132.

Verify the documentation diff and open a PR in articulate/docker-node. Return a concise outcome with the PR URL, verification performed, any blockers, and sources read.

Source: https://articulate.slack.com/archives/C0C38QZ264B/p1794506584719799?thread_ts=1794506584.719799&cid=C0C38QZ264B . Direct requester instruction: "update the docker-node repo README to officially recommend node 26. Keep lambda at node 24 for now".

Coder report

The README now recommends articulate/node:26 for services and articulate/node:24-lambda for Lambda. The 🌟 marker sits on those two tags, and a short note above the list says the same thing in words.

What changed in the Tags section:

  • I removed the "(preview; not LTS)" label from Node 26 and added no new lifecycle wording, so the README makes no claim about LTS or support status either way.
  • The 🌟 moved off articulate/node:24 and articulate/node:22 and onto articulate/node:26. Leaving those stars in place would have kept three general recommendations alongside 26, so this is the one judgment call in the diff.
  • The new note says there is no Node 26 Lambda image yet. The repo backs that up: 26/ contains only base/, while 20/, 22/ and 24/ each have a lambda/ image.

I did not touch articulate/todonnell-testing or PR #132.

Verification:

  • Reviewed git diff: only README.md changed, and only the Tags section.
  • grep for LTS, preview, EOL, maintenance and "current" in the edited README found nothing.
  • markdownlint-cli2 reported 0 issues, the same as the unedited README.
  • The new lines are under 80 characters, matching the surrounding text.

Blockers: None. No internal knowledge base was available here, so I checked only the conventions in the repo itself.

Sources read:

  • README.md
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/CODEOWNERS
  • .github/workflows/lint.yml
  • The 20/, 22/, 24/ and 26/ directory layouts, plus 26/base/Dockerfile, 24/base/Dockerfile and 24/lambda/Dockerfile (their tag comments and base images)
  • The requester's Slack instruction

Source: a direct request
Requested by Leo Lin (Slack @Leo Lin).
Opened by catzo.


Model: anthropic/claude-opus-5-5
Reasoning: high

@leoxlin
leoxlin marked this pull request as ready for review November 12, 2026 18:17
@leoxlin
leoxlin requested a review from a team as a code owner November 12, 2026 18:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T18:18:05.194302Z 6e9d5c2 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-12T18:19:12.508450Z 6e9d5c2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoxlin
leoxlin added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 3768bd7 Nov 12, 2026
20 checks passed
@leoxlin
leoxlin deleted the chore/b680c3ac-recommend-node-26 branch November 12, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant