Repository navigation
deps: drop unused consul/api v2 requirement - #357
Merged
Merged
Conversation
ivorisoutdoors
marked this pull request as ready for review
November 5, 2026 15:18
This reverts commit 1e2b7fc. The rule now lives in articulate/org-renovate so every repo that extends the preset gets it.
dholmes
approved these changes
Nov 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#351 added
github.com/hashicorp/consul/api/v2 v2.0.0to go.mod but left every import ongithub.com/hashicorp/consul/api, so the v2 requirement is unused. Moving the imports to v2 would be a downgrade. HashiCorp taggedapi/v2.0.0in May 2026,api/v1.35.0in October 2026, and their main branch still publishes the client asgithub.com/hashicorp/consul/api. v2.0.0 is missing code that v1.35.0 has and pins older dependencies. The parts of the client this repo uses (api.go,kv.go) are identical in both versions, so neither one breaks anything here.This PR runs
go mod tidyto drop the unused v2 requirement and its stale go.sum lines. The Renovate rule that keepsconsul/apibelow v2 lives in the org preset (articulate/org-renovate#56), so this repo picks it up without a local rule. Until that merges, the next Renovate run can open the/v2import rewrite again.Reviews
code-review, Codex,gpt-6.1-sol): approved throughbbcfaa6Harness:
Claude CodeModel:
Opus 5.5