Skip to content

deps: drop unused consul/api v2 requirement - #357

Merged
ivorisoutdoors merged 3 commits into
mainfrom
deps/drop-consul-api-v2
Nov 5, 2026
Merged

ivorisoutdoors merged 3 commits into
mainfrom
deps/drop-consul-api-v2

Conversation

@ivorisoutdoors

@ivorisoutdoors ivorisoutdoors commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

#351 added github.com/hashicorp/consul/api/v2 v2.0.0 to go.mod but left every import on github.com/hashicorp/consul/api, so the v2 requirement is unused. Moving the imports to v2 would be a downgrade. HashiCorp tagged api/v2.0.0 in May 2026, api/v1.35.0 in October 2026, and their main branch still publishes the client as github.com/hashicorp/consul/api. v2.0.0 is missing code that v1.35.0 has and pins older dependencies. The parts of the client this repo uses (api.go, kv.go) are identical in both versions, so neither one breaks anything here.

This PR runs go mod tidy to drop the unused v2 requirement and its stale go.sum lines. The Renovate rule that keeps consul/api below v2 lives in the org preset (articulate/org-renovate#56), so this repo picks it up without a local rule. Until that merges, the next Renovate run can open the /v2 import rewrite again.

Reviews

  • GPT (code-review, Codex, gpt-6.1-sol): approved through bbcfaa6

Harness: Claude Code
Model: Opus 5.5

@ivorisoutdoors
ivorisoutdoors marked this pull request as ready for review November 5, 2026 15:18
@ivorisoutdoors
ivorisoutdoors requested review from a team and botzo as code owners November 5, 2026 15:18
This reverts commit 1e2b7fc. The rule now lives in articulate/org-renovate so every repo that extends the preset gets it.
@ivorisoutdoors ivorisoutdoors changed the title deps: drop unused consul/api v2 and keep Renovate on v1 deps: drop unused consul/api v2 requirement Nov 5, 2026
@ivorisoutdoors
ivorisoutdoors added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 644feeb Nov 5, 2026
7 checks passed
@ivorisoutdoors
ivorisoutdoors deleted the deps/drop-consul-api-v2 branch November 5, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants