Repository navigation
kvspace: harden XValue ABI, ELF destructor cleanup, CLI formatting, and v0.3.23 tutorials - #50
Merged
Merged
Conversation
- Embed relative RUNPATH entries for both release tarballs and cmake --install - Verify CLI RUNPATH in release workflow instead of rebuilding with cargo - Point kvspace.pc libdir to lib/kvspace and run ctest in CI - Align README backend search order with frontend.c
…ctor - Add kvspaceXvalueHeadLangtypeBounded to validate attr bounds against wire_len - Clear *out on constructor failure and validate storetype in Reserve via build() - Clarify leaf Ptr resolution and wire-level untyped traversal contracts in kvspace.h - Treat kvspaceXvalueBodyView as optional in frontend (-2 when absent) - Use __attribute__((destructor)) instead of atexit for exit handle cleanup to avoid UAF - Add unit tests covering bounded langtype parsing and constructor failure contracts
…false - Parse leading [dims] from langtype for head output and format numeric tensors element-wise - Detect extindex mounts via head.ptr=2 and skip mounted expansion when showext=false - Propagate deletion errors on 'set <key> nil' and remove dead FFI helpers
- Pass langtype to New* and WriteNewPlace across C, C++, Python, and Rust examples - Read body length from fixed 8-byte header and parse inline langtype with bounded helper - Default test.py library lookup to /usr/lib/kvspace with KVSPACE_LIB override
… #571 ABI - Remove deprecated index:/map[]:/ro/vid syntax and isolate per-script prefix cleanup - Update test.py ctypes bindings for current HeadV, New*, and WriteNewPlace signatures
carsontung666
force-pushed
the
fix/review-v0.3.23
branch
from
November 1, 2026 06:22
1ad4f8b to
98562f3
Compare
carsontung666
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kvspaceXvalueWireLangtypeViewreader, clear*outon constructor failure, validatestoretypeinReserve, and switch frontend exit cleanup fromatexitto an ELF destructor.dimsfromlangtypein CLIhead/value output, format fixed-width tensor elements, and honor--showext=false.RUNPATHfor both tarball andcmake --installlayouts, enablectestin CI, and aligntutorial-c/tutorial-durablewith the v0.3.23#571ABI.Verification
ctest --test-dir build --output-on-failure: 2/2 passed.cargo test --manifest-path cli/Cargo.toml: passed.tutorial-c/test.py: 11/11 passed;tutorial-durable/test.py: 19/19 passed.