Repository navigation
feat: v0.3.23 ABI 对齐与 Ptr/volatile 修复(review #45,冲突取 PR 方) - #47
Merged
Merged
Conversation
按用户裁决把 review PR #45 落到当前 main:冲突取 PR 方;并补回被冲突块吞掉的 开发期不变量(kvspaceWriteInPlace body 指针 8 字节对齐 debug_assert)。 - Ptr 链解析(≤16 跳)、ListLen/ListAt 遍历缓存 O(N)、DelTree 范围 - volatile 跨进程失效与 4 槽环形缓冲(未变槽原地复用) - ctime 变化时退役跨句柄缓存函数条目、Redis 重连与 panic 兜底、fs 原子写 - v0.3.23 ABI 回归测试套件、deps.json 新增 kvspace v0.3.23 pin 已知后果(留档):body-only 守卫让位后 durable 的 SetPart 无范围校验 (fs pwrite / redis SETRANGE),reserved key 仅 fs 后端检查 —— 见 ci-followups ⑪。 Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
把 review PR #45 落到当前
main,冲突一律取 PR 方(用户裁决),并补回一个被吞掉的开发期不变量。做法
main(7c48cae,含 #46 SetPart 范围校验)上应用 coding4 的解冲突整树 patch(22 文件 +1998/−725)。冲突:
src/ffi.rs两处取 PR(SetPart的 Ptr 解析 + 后端调用、WriteInPlace的pending_key = target_key);WriteNewPlace非冲突区自动合并。补回的不变量(独立小改,不影响 PR 语义)
kvspaceWriteInPlace的debug_assert!(body_ptr % 8 == 0)在取 PR 方时被删且无替代,本提交加回(debug 构建断言、release 零开销):body 指针供调用方直接写 8 字节标量,
对齐是前条件不是假设。
验证
cargo test --release --offline— 全部 suite 绿,合计 51 passed / 0 failed(lib 34、deltree 1、cp 2、list_cache 2、map_coord 2、metadata_fs 2、prefix_list 3、
read_cache 3、review_fixes 2,另若干 0 用例 suite)。
作者报 lib 34 passed、rc=0,一致。
⚠ 已知后果(必须随提交留档)
body-only 守卫让位后:durable 的
SetPart完全无范围校验(fs 走 pwrite、redis 走SETRANGE),reserved key 只在 fs 后端检查、redis 没有。attr/head 保护现在只靠调用方自律。
详见 ci-followups ⑪。
🤖 Generated with Claude Code