Repository navigation
feat(shm): support full value writes by key reference - #42
Open
carsontung666 wants to merge 2 commits into
Open
carsontung666 wants to merge 2 commits into
carsontung666 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add an optional full-value write by key reference. It validates the complete XValue and preserves normal write, metadata, extension, and diagnostic behavior. References identify shared ART nodes; value contents and allocation capacity remain in shared memory.
Preserve the original reference when virtual-path refresh fails, preventing subsequent reads from using an unrelated node.
Validation
7/7 CTests; independent review matched normal writes across 520 differential cases, including metadata changes, malformed values, ART growth, deletion/recreation, extensions, and parent references.
Joint default-runtime benchmark with kvlang #364 and kvspace #29: all 10 workloads / 30 frozen scales, 9 alternating pairs, matching Python outputs. Algorithm geometric mean: 1.207x; whole CLI: 1.021x. This is a combined runtime/backend result, not an isolated backend speedup. Raw results and conditions.