fix: avoid case-insensitive source directory collision - #40
Open
MuNeNiCK wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On case-insensitive filesystems, the Lean module directory
Blake3/and the cloned C source directoryblake3/resolve to the same path. Downstream Lake builds on macOS and Windows can therefore remove or overwrite the Lean sources while materializing the C implementation.Clone the upstream BLAKE3 sources into
blake3-source/instead. This keeps the existing build and API unchanged while allowing both directories to coexist.Tested with:
lake test