feat: support indirect parameters for exported functions - #222
Open
Xe wants to merge 1 commit into
Open
Conversation
The ABI passes a function's parameters on the stack when your function (or a record passed to that function) has 16 or less parameters (including record fields). Past that limit the caller has to malloc into the guest for copying parameters over. Implement wit-bindgen's Instruction::Malloc for guest exports by calling cabi_realloc in the guest and using those pointers to write data. Test coverage was added to the instructions example to ensure this doesn't incur regressions. Assisted-by: Claude Opus 5 via Claude Code Signed-off-by: Xe Iaso <me@xeiaso.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ABI passes a function's parameters on the stack when your function (or a record passed to that function) has 16 or less parameters (including record fields). Past that limit the caller has to malloc into the guest for copying parameters over.
Implement wit-bindgen's Instruction::Malloc for guest exports by calling cabi_realloc in the guest and using those pointers to write data.
Test coverage was added to the instructions example to ensure this doesn't incur regressions.
Assisted-by: Claude Opus 5 via Claude Code