[4.x] Correct job order in DeletingTenant pipeline

[lukinovec]

In the DeletingTenant job pipeline example in the TenancyServiceProvider stub, Jobs\DeleteTenantStorage::class is positioned before Jobs\RemoveStorageSymlinks::class. After uncommenting both, RemoveStorageSymlinks calls $tenant->run() (via possibleTenantSymlinks) which creates the directory already deleted by DeleteTenantStorage.

Swap the order of these jobs so that the cleanup works as expected (= tenant storage directory gets deleted with tenant).

Summary by CodeRabbit

• Refactor
  • No user-facing changes in this update. Existing tenant-deletion behavior and available functionality remain unchanged. This release does not enable or remove any capabilities, and there are no new features or bug fixes to highlight.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 4de64a5c-11a1-4acf-a0ca-2a413fec73ac

📥 Commits

Reviewing files that changed from the base of the PR and between 7681326 and 6ecf067.

📒 Files selected for processing (1)

• assets/TenancyServiceProvider.stub.php

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The stub reorders two commented jobs in the tenant-deletion pipeline. Both jobs remain disabled.

Changes

Tenant deletion pipeline

Layer / File(s)	Summary
Commented job order assets/TenancyServiceProvider.stub.php	The commented Jobs\RemoveStorageSymlinks entry now precedes Jobs\DeleteTenantStorage. Neither job is enabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6ecf0

Only the example order of two disabled jobs changes, so tenant-deletion execution is unaffected and no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the change: correcting the job order in the DeletingTenant pipeline.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{I’m a rabbit, hopping by,
Two quiet job lines switch their place.
Still commented, neither takes the sky,
I nibble clover, leave no trace.
Then bound away at gentle pace.}

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (7681326) to head (6ecf067).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1492   +/-   ##
=========================================
  Coverage     86.89%   86.89%           
  Complexity     1252     1252           
=========================================
  Files           186      186           
  Lines          3654     3654           
=========================================
  Hits           3175     3175           
  Misses          479      479           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.