Repository navigation
fix: bump vulnerable dependencies to patched versions - #2126
Merged
Merged
Conversation
🟢 Tier S · Ready to merge
Updates the Swift example package resolutions, refreshes the mock server's Composer dependencies to the newer database line, and bumps the generated Python test extra's Black pin with a Python version marker. The dependency lockfiles now capture the refreshed package versions.
📂 Walkthrough · 5
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes the open Dependabot alerts in the Swift example
Package.resolvedfiles andmock-server/composer.lock, and fixes the Python template so the generated SDK stops shipping a vulnerable black pin.Swift examples. Both
Package.resolvedfiles were years stale (swift-nio 2.38 / 2.63, whilePackage.swift.twignow requiresfrom: "2.102.0"). I generated the Apple SDK withphp example.php apple, deleted the old pins, ranxcodebuild -resolvePackageDependenciesonexample-uikit/UIKitExample.xcodeprojandexample-swiftui/Example.xcodeproj, and copied the fresh files back. Xcode 27 writes the version 3 format, and every pin carries the upstream tag commit SHA.Mock server.
mongodb/mongodb1.10.0 (GHSA-8fxw-fmj8-xp7j, GHSA-65fr-j4p9-vc33) was pinned exactly byutopia-php/mongo0.3.1 throughutopia-php/database0.48, so no lockfile refresh could fix it.utopia-php/database^5.3 is the newest line that still works with PHP 8.4 (the mock server image) and does not needutopia-php/frameworkbeyond 0.33. Itsutopia-php/mongo1.5.4 no longer depends onmongodb/mongodbat all. The mock server only usesDocumentandIDfrom it, and both behave the same.google/protobuf(GHSA-p2gh-cfq4-4wjc) moves along with it.utopia-php/frameworkstays at 0.33.34 on purpose: 0.33.38 renamedUtopia\ApptoUtopia\Http, which breaksapp/http.php.Python template.
templates/python/pyproject.toml.twigpinnedblack==25.11.0(GHSA-3936-cmfr-pm3m). The fix only exists in black 26, which requires Python 3.10, so the pin isblack==26.10.1; python_version >= '3.10'andpip install .[test]keeps working on 3.9. 26.10.1 matches the version this repository's validation workflow already uses. appwrite/sdk-for-python#167 makes the same change in the generated repository.Verification
composer auditinmock-server: no security vulnerability advisoriesdocker compose build && docker compose upinmock-server:mockapiandmqttstart ("Server started successfully")vendor/bin/phpunit tests/e2e/Python312Test.php: OK (1 test, 207 assertions), which runs the generated Python SDK against the rebuilt mock servervendor/bin/phpunit --testsuite Generation: OK (167 tests, 4 skipped)xcodebuild -resolvePackageDependencieson both example projects: resolves cleanlyRelated: appwrite-labs/cloud#6671