Repository navigation
Log one structured line per HTTP request - #5
Merged
Merged
Conversation
Wrap the server handler with appserver-go requestlog and record the failures that only wrote a response. (appserver-go pinned to the PR commit until v0.7.0 is tagged.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Built-in apps emit no access log and hide most failures: after container log collection was enabled on Craftsman (2026-11-18), opening the production Builder Console produced zero lines. Tracking issue: APT-1314.
What
requestlog.Wrapfrom appserver-go (requestlog: one structured line per HTTP request appserver-go#9): one JSON line per request with method, path, route, status, bytes, duration and request id. No query strings, headers or bodies. Successful/healthzand/readyzare not logged.Draft until
appserver-go v0.7.0 is tagged.
go.modcurrently pins the PR commit (5f8bf82); it will be replaced withv0.7.0before this leaves draft.Verification (local)
go vet ./...andgo test ./... -count=1against a disposable Postgres, no skipped tests.