Repository navigation
Conversation
…270) - controller-release.yml: the release image is built, attested and signed only in runs started by a v*.*.* tag push; main pushes keep producing :edge from a job without signing permissions; workflow_dispatch is removed - one multi-platform build per release to a local OCI layout, copied to GHCR with digests preserved and compared byte for byte; the index has exactly the linux/amd64 and linux/arm64 children and no in-index attestation manifests - signed SLSA provenance for the index and for each child, and a keyless signature on the index; release tags are applied after signing - builder, base, BuildKit, Dockerfile frontend and the signing tool are pinned by digest; actions by commit; no imported build cache in the release build
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the owner
features/security/reviewed-import-image-provenance/design.md, sections 3 R2 and 5). The controller release image gets verifiable build evidence: who built it, from which commit, in which workflow run. Today'sghcr.io/appthrust/dns-apiv0.4.8 has none.main): nothing is signed and no release is cut.mainkeeps producing the:edgeimage and the0.0.0-edgechart as before, now from a job that holds no signing permission. Manualworkflow_dispatchof this workflow is removed.v*.*.*tag: the release image is built once for linux/amd64 and linux/arm64, pushed, and only then signed and tagged. It carries a signed SLSA provenance statement for the index and for each platform image, and a keyless signature on the index, all from that one run.mainis one commit past v0.4.8 (bcd96ab, APT-822). The platform slot is replaced only by a later, separately approved platform change (slice S3).Changes
.github/workflows/controller-release.ymlrelease-image: runs only for a pushed tag (push, not deleted,refs/tags/v…). It is the only job withid-tokenandattestationspermission; the workflow default is no permissions.actions/attest-build-provenance(pinned by commit) for the index and each child, by digest;cosign(digest-pinned image) signs the index. Release tags are applied last, so a failed run leaves no release tag.edge-image: the previousmainbehaviour (:edge), without signing permission.push-helm-chart: unchanged behaviour; actions pinned by commit.Dockerfile: builder and runtime base images pinned by digest (golang:1.26.2,gcr.io/distroless/static:nonroot).Not in this change
Verification
actionlintclean; one local linux/amd64 build with the pinned inputs succeeded.