Repository navigation
gatewayendpoint: replay the platform Gateway Fleet publication contract (APT-822) - #28
Merged
Merged
Conversation
…ct through a restarted reconciler set (APT-822) - Byte-identical copy of platform's publication-dns-contract/v1 fixtures (real Fleet output, SHA256SUMS). - Per scenario a fresh client, provider adapter and reconciler set (restart, empty cache) must retain live names with no Route 53 DELETE, or withdraw exactly the expected names. - Reverting D4 (route-level Accepted=False withdraws) fails leaf-policy-status-absent and policy-rejected. - Convergence ignores only hostname condition lastTransitionTime churn (APT-1185) and resourceVersion.
Contributor
Author
|
Producer side: https://github.com/appthrust/platform/pull/6980. Fixtures are byte-identical (SHA256SUMS). |
…retained publications (APT-822 review) - Retain scenarios now also require zero provider UPSERTs. - README synchronized byte-for-byte with platform (drift gap APT-1187, coverage limits).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (APT-822, platform ADR-0083)
The Project DNS outages of 2026-11-12 (Craftsman) and the same withdrawals on appthrust.ink were a chain across two repositories: the platform Gateway Fleet wrote a source HTTPRoute status during a transient control-plane state, and dns-api read it as a reason to withdraw a live name. Each side had its own tests with hand-built inputs; nothing fed the Fleet's real output into dns-api.
Change (tests only)
internal/go/apps/gatewayendpoint/controllers/gateway/testdata/publication-dns-contract/v1/: 12 source Gateway/HTTPRoute fixtures generated by the platform Gateway Fleet reconciler (platform PR: see below), byte-identical copy,SHA256SUMS, README (ownership, regeneration, wire format).publication_dns_contract_test.go(TestPublicationDNSContract): verifies checksums and the 12-scenario inventory; establishes 13 healthy names with real receipts, child RecordSets and provider records; then, per scenario, rebuilds a fresh client, provider adapter and all four reconcilers from the persisted state (a dns-api restart with an empty cache), applies the captured Fleet output and reconciles to convergence (≤16 passes).AcceptedConvergence ignores only
resourceVersion/managedFieldsandstatus.hostnames[].conditions[].lastTransitionTimeon EndpointRecordSets: the endpointrecordset reconciler restamps that time on every reconcile without a transition (platform tracker APT-1185, confirmed on appthrust.ink). Those status-only writes are counted and logged, not failed. No production change in this PR.Verification
go test ./internal/go/apps/gatewayendpoint/controllers/gateway/ -count=1→ ok;go vet→ ok.Accepted=Falsewithdraws again,controller.go:316) makesleaf-policy-status-absentandpolicy-rejectedfail with "retained publication sent Route 53 DELETE: [alias.project.example. app-00.project.example.]"; every other scenario still passes.leaf-unreachable.needs-human-reviewis not a label in this repository; please treat this PR as review-required (no auto-merge).