Repository navigation
gatewayendpoint: honour gateway.endpoint.dns.appthrust.io/excluded-listeners - #24
Merged
Merged
Conversation
…steners Listener sections named in the annotation are excluded from publication and from retained receipts, so a Platform Gateway may serve a managed domain (dashboard instances at <org>.appthrust.app) without emitting wildcard records that the Zone contract forbids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform (appthrust/platform, ADR-D122 I1) will serve per-tenant Dashboard instances at
<org>.appthrust.appfrom the installation'splatform-publicGateway by adding*.appthrust.applisteners. Theappthrust.appZone contract forbids wildcard records; only exact<org>/<app>.<org>names from the allocation-writer namespace are allowed.This change lets a Gateway opt listener sections out of endpoint publication:
gateway.endpoint.dns.appthrust.io/excluded-listeners= comma-separated listener section names.Adoption order: this must be deployed before Platform enables
PlatformInstallation.spec.managedDomains[].serveDashboardsFromPlatformGateway; an older dns-api ignores the annotation and would attempt a wildcard record (rejected by the Zone, but noisy).Verification:
go test ./internal/go/apps/gatewayendpoint/controllers/gateway(exclusion of publication + retained receipts, unchanged behaviour without the annotation). README updated.