Repository navigation
feat: role-based views — launcher home, intro page, inbox, contribution policy, proxy authority - #47
Merged
Merged
Conversation
…on policy, proxy authority - Server: pure domain.Capabilities (use/comment/propose/maintain/data) returned as app.permissions; me.view user|maker; apps.contribution_scope (migration 010, default group) editable via PATCH; GET /inbox (pending access requests, unseen feedback) and POST comments/seen; console_authority gates the same-origin Platform proxy: improvement drafts need propose (403 contribution_not_accepted when only scope=off blocks), database rows/sql/script/credentials/changes need data, logs/rollback need maintain. - Web: canEditApp removed in favour of app.permissions; user view = 3-item nav, launcher home with filter chips, cards open the app; non-maintainers get a tab-less intro page on every tab URL with 担当者に伝える and 直しを提案する; maintainers get あなたの対応待ち (useInbox), 利用者の声, 紹介がまだ足りません, 利用者にはこう見えます, and the 提案の受け付け setting. Mock gains Editor persona, inbox, seen, and the propose refusal. - Design: nexus features/builder-console/role-based-views (domain-model, ux-design, wireframes).
…story - Restores the group-page round trip that the launcher home no longer reaches from the home sections.
…w the launcher home; keepalive on comments/seen - TestServedOpenAPIEqualsCommittedContract compares the served document with internal/api/openapi.json (SDK compatibility is covered separately). - Stories: access-request approval reads the inbox row, delete assertions scoped to the app table, migration counts include the Editor persona. - POST comments/seen uses keepalive so the read receipt survives navigation (was aborted, surfacing as a browser transport error).
…ne else - A fresh app issued POST comments/seen on overview mount and the request was aborted by navigation; the write was also a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Craftsman feedback (2026-11-19): users do not know what to do on the console home or on an app page; data under
/-/datamust not be visible to users; users want to leave feedback as comments; proposals should be open by default to people in the app's department who can build, with acceptance as an app setting.Design (Japanese, Nexus):
features/builder-console/role-based-views/—domain-model.md,ux-design.md,wireframes.md.What
Server (
cmd/server)domain.Capabilities(actor, app)→app.permissions {use, comment, propose, maintain, data}, one pure function;me.view: user|maker.apps.contribution_scope(off|group|company, defaultgroup; migration010), editable viaPATCH /apps/{id}.GET /inbox(pending access requests, unseen feedback for apps I maintain),POST /apps/{id}/comments/seen.console_authority.goreplacesdraft_reviewers.goand gates the same-origin Platform proxy: improvement drafts needpropose(403contribution_not_acceptedwhen onlyscope=offblocks), database rows/sql/script/temporary-credentials/changes needdata, logs and rollback needmaintain. Database→app resolution reads only console apps' own stacks, memoized per request.Web
canEditAppremoved; everything readsapp.permissions.useInbox, single composition point), 「利用者の声」 with 「これを AIで直す」 (editable draft), 「紹介がまだ足りません」, 「利用者にはこう見えます」 (?as=user), settings 「提案の受け付け」.Editorpersona, inbox, seen, propose refusal.Not in this PR
DataPolicyprojected to Platform (DataAccessPolicy) so Dashboard/CLI paths are closed too — wave 2, platform repo.companycontribution scope is stored/served but not exposed in the settings UI.Verification
go build ./...,go vet ./cmd/server/...,go test ./cmd/server/internal/domain/ ./cmd/server/internal/api/ok.web:bun run typecheck0 errors;bun test src2169 pass / 0 fail; mock storiesdiscover-navigation,build-failure-causepass./sales/planning/hikkoshi/-/datarenders the intro page with no tabs and no ログ/イメージ/ポート/version text; Editor sees 「直しを提案する」 on own-group apps and not onscope=off; Owner?as=usershows the banner; settings toggle persists.Review
Authority change (proxy gating, new permission surface) →
needs-human-review; auto-merge not armed.