Skip to content

Announce a recreated workspace once instead of switching silently (APT-1264) - #44

Merged
reoring merged 6 commits into
mainfrom
feat/apt-1264-workspace-recreated-notice
Nov 19, 2026
Merged

reoring merged 6 commits into
mainfrom
feat/apt-1264-workspace-recreated-notice

Conversation

@reoring

@reoring reoring commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What (APT-1264 — decided design, 森さん 2026-11-18)

Never switch a workspace silently. When a conversation turn or plan generation carries replacedDevWorkspaceId (Platform recreated a retired or missing workspace), the build conversation shows once, as information only: 「作業環境を作り直しました。会話と計画は引き継いでいます」 / "Your workspace was recreated. The conversation and plan are kept."

  • web/src/api/contracts/platform/build.ts: turn and generation readers accept the optional field (local extension; older Platforms omit it).
  • web/src/model/build/messages.ts: workspaceRecreatedNotices derives the notice from the draft (no local state), once per retired workspace, at the earliest record naming it; no retry, no reference.
  • Copy in model/build/copy.ts / copy.en.ts.

Covered screens: the build conversation, improve (AIで直す), and Excel → app analysis and preview chat. One pure selector (recreatingRecords) picks the earliest record per retired workspace. The notice is display-only (kind: 'workspace-recreated'); build-page decisions (re-approval, plan rejection, generation limit) read the last actionable message.

Not covered: console-v1 (ConsoleBuildPage) — left unchanged. Showing the notice there needs an earlier draft read that, in review round 3, let a stale plan be approved while a re-plan loads. PO lead decision (a): ship the other screens first; console-v1 is tracked in APT-1282 (high).

Local verification

bun run typecheck, bun run typecheck:e2e, bun test src (2144 pass / 0 fail), check:response-boundaries (0 violations), check:console-schema — all exit 0.

Platform counterpart: appthrust/platform PR (APT-1264). Writer: Claude Opus 5.5 (designer). Review: GPT family (see PR comment).

…T-1264)

- Read replacedDevWorkspaceId on conversation turns and plan generations (optional; older Platforms omit it).
- Show 「作業環境を作り直しました。会話と計画は引き継いでいます」 once, on the record that replaced the
  retired workspace, as information only; derived from the draft so reloads keep exactly one notice.
@reoring reoring added the needs-human-review Waits for a person's review before merge label Nov 18, 2026
…PT-1264 review)

- One pure selector (recreatingRecords): earliest record per replacedDevWorkspaceId, derived from the draft.
- Improve conversation, Excel → app analysis and preview chat, and console-v1 plan requests (by platformGenerationId) show the notice.
- The notice is display-only (kind workspace-recreated); build-page decisions read the last actionable message.
- The notice sits right after its request and before the answer, also at equal times or without finishedAt.
… plans and only on the shown analysis (APT-1264 review)

- console-v1 reads the draft once a plan request names a Platform generation (failed first plans included).
- A plan turn naming a generation the last draft read lacks refetches the draft once per turn update.
- Excel → app analysis shows the notice only when the analysis on screen itself replaced the workspace.
…PT-1282

- Restore console-build-page, console-conversation and console-view (and their tests) to main.
- Showing the notice there needs an earlier draft read that let a stale plan be approved while a re-plan
  loads (review round 3); PO lead decision (a): ship build, improve and Excel → app first.
…nits)

- The shared notice's comment names only improve and Excel → app; the build notice factory is module-private.
@reoring

reoring commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Independent review (GPT-6 Astra probe-astra, writer Claude Opus 5.5 designer): rounds 1–3 "変更が要る"; after PO lead decision (a) removed the console-v1 notice (APT-1282), round 4 at 3cc77be: マージしてよい。後続つき (two nits fixed in c2923c8: comment scope, module-private factory). Local: typecheck, typecheck:e2e, bun test src 2144/0, check:response-boundaries, check:console-schema all exit 0 at 3cc77be; typecheck + focused tests 187/0 at c2923c8. Record: Nexus po/lead-2026-11-14/reviews/builder-console-44-review-bugfixer.md.

@reoring

reoring commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Nit-diff confirmation (GPT-6 Astra probe-astra, writer Claude Opus 5.5) at c2923c8: マージしてよい — the diff from 3cc77be is the two nits only (comment scope, module-private factory); no other importer, no behaviour change. Record: Nexus po/lead-2026-11-14/reviews/builder-console-44-review-bugfixer.md (round 5).

@reoring reoring removed the needs-human-review Waits for a person's review before merge label Nov 19, 2026
@reoring
reoring merged commit e149d15 into main Nov 19, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant