Add backend selection to the TelemetryStack form - #1187
Merged
Merged
Conversation
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
RokibulHasan7
force-pushed
the
rakib-vt
branch
from
September 28, 2026 09:22
f2542af to
3287695
Compare
Keep page `if` as `isActivePage|<page>` so each page's errors are counted under its sidebar item again, and move the backend check to an inner block so fields of an unselected backend are neither validated nor submitted. Hide the sidebar items of unselected backends and give VictoriaMetrics and VictoriaLogs their own icons. Make every VictoriaMetrics and VictoriaLogs field required except the licence Secret and key, validate Future Retention and Max Disk Usage %, and turn their Storage Class into a dropdown that preselects the saved, default or only StorageClass. Carry over the earlier fixes: Store sharding Type as a select, volume rows gated on volumeType, and default compact retention of 2d/14d/30d. Signed-off-by: Sourav Roy <souravroy@appscode.com>
Nihal-Azmain
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.