Avoid null spec.valuesFrom in Feature templates - #1346
Merged
Merged
Conversation
Bare 'valuesFrom:' renders as null, which the apiserver rejects under server-side apply (Helm v4 / helm-controller >= v1.5.0 default for new installs). Client-side apply silently prunes it, hiding the bug. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
arnob-null-valfrom
branch
3 times, most recently
from
September 28, 2026 08:45
2cf6528 to
e4925a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-OpenShift clusters, 33 Feature templates in `opscenter-features` (and `cert-manager` in `ace-installer`) render a bare `valuesFrom:` → `null`. The Feature CRD types it as an array, so server-side apply fails:
Client-side apply (Helm v3) prunes the null, so this only surfaces with Helm v4 / helm-controller >= v1.5.0, which defaults new installs to SSA. Reproduced on vanilla kube-apiserver v1.35.0 and v1.36.2 (SSA fails, create succeeds on both).
Fix: move `valuesFrom:` inside the `distro.openshift` conditional; drop the always-empty one in cert-manager.
ace-installer-certifiedstill needs regeneration via chart-packer.