Skip to content

fix: replace all hyphens in runtime SDK versions and reject non-finite coordinates - #317

Merged
mykola-mokhnach merged 1 commit into
appium:masterfrom
hoanle0126:fix/sdk-runtime-hyphen-replacement-and-location
Nov 4, 2026
Merged

mykola-mokhnach merged 1 commit into
appium:masterfrom
hoanle0126:fix/sdk-runtime-hyphen-replacement-and-location

Conversation

@hoanle0126

Copy link
Copy Markdown
Contributor
  • In getDevices, .replace('-', '.') only replaced the first hyphen in runtime keys (turning three-part identifiers like com.apple.CoreSimulator.SimRuntime.iOS-17-5-1 into '17.5-1' instead of '17.5.1'). Use .replace(/-/g, '.') to match createDevice's .replace(/\./g, '-').
  • In setLocation, check Number.isFinite(flt) instead of isNaN(flt) so Infinity / -Infinity throw a TypeError instead of passing 'Infinity' to simctl location.

@mykola-mokhnach
mykola-mokhnach merged commit 3b9f192 into appium:master Nov 4, 2026
8 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 4, 2026
## [9.1.2](v9.1.1...v9.1.2) (2026-11-04)

### Bug Fixes

* replace all hyphens in runtime SDK versions and reject non-finite coordinates ([#317](#317)) ([3b9f192](3b9f192))
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants