Skip to content

Toolify post-merge: safe embeds, share UX and manual-only Actions for all workflows (DRAFT) - #41

Draft
appdevelopsk wants to merge 96 commits into
mainfrom
fix/toolify-postmerge-embed-safety-20261107
Draft

appdevelopsk wants to merge 96 commits into
mainfrom
fix/toolify-postmerge-embed-safety-20261107

Conversation

@appdevelopsk

@appdevelopsk appdevelopsk commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Status: DRAFT / NO-GO

PR #40 is merged; superseded PR #38 is closed without merge. PR #41 contains post-merge hardening. Do not merge or deploy based on isolated test results. GitHub Actions were not invoked.

Implemented

  • HTML-safe iframe and attribution link builder. Reject credentials, control characters, unsafe/relative schemes and remote HTTP; preserve valid HTTPS/local-development links.
  • ShareBar uses the isolated helper; new Vitest tests and dependency-free Node execution tests cover the embed builder.
  • On this PR branch only, the deploy workflow is manual-only (on: workflow_dispatch), keeping VPS lock and release-SHA checks. Current main retains its preexisting auto-deploy workflow until an authorized merge.
  • Root scripts/check-postmerge-embed-release.sh checks its exact branch, fetches current origin/main, requires ancestry, and uses the strict scripts/verify-manual-deploy.mjs parser to reject all unreviewed workflow event syntax (including on: [push], inline event lists/mappings, duplicate events). It then runs four dependency-free verifier regression test groups, six embed Node tests, npm install, smoke/integration, typecheck, Vitest, validation, SEO/i18n/index audits and Next build.

Executed evidence (not simulated)

  • Exact GitHub-blob-matched verifier and test source materialized locally. node --test verify-manual-deploy.test.mjs: 4/4 passed, including actual CLI accept (0) and reject (4).
  • Exact GitHub-blob-matched release gate bash -n: passed. Actual CLI rejects on: [push] with exit 4.
  • Fetched real PR41 deploy workflow; event-block verification found one manual-dispatch block and no unexpected events.
  • Previously, exact GitHub-blob-matched embed HTML source/test ran under Node 22.16: 6/6 passed, isolated TypeScript strict check passed.
  • Latest compare 42 commits ahead of main, zero behind, 10 changed files; no submitted reviews or successful status checks.

Release blockers

  • Full private repo checkout/npm ci, project-wide Vitest, complete production Next.js build, cross-browser mobile/desktop/17-locale QA, ad/consent & GA4 DebugView validation, and deployment remain unverified.
  • Owner-accessible checkout must run bash scripts/check-postmerge-embed-release.sh on fix/toolify-postmerge-embed-safety-20261107, fix any failures, review the workflow trigger change and browser behavior, then approve PR41. Owner performs manual production deploy and SITE_URL=https://toolify365.com npm run audit:live-growth.

Full evidence: docs/PR40_POSTMERGE_FOLLOWUP_2026-11-07.md. No traffic, conversion or revenue uplift claimed.

2026-11-07 15:21 JST update: release origin and business validation

  • The local release gate now exports NEXT_PUBLIC_SITE_URL=https://toolify365.com before npm ci, audits and production build. Without it, siteConfig.url defaults to https://example.pages.dev, risking incorrect canonical, share, iframe, and SEO URLs.
  • Verified the production public character-frequency tool displays a Text Batch Studio CTA; Text Batch Studio and JSON Studio are live as browser-local free tools, but currently state that paid plans/payments are unavailable. The code also intentionally blanks AdSense client and ad slots. These are separate monetization blockers; DO NOT claim SEO uplift equals paid revenue.
  • During this review other ShareBar cancellation handling changes landed on this branch. Confirmed current source imports isShareCancelled, avoids clipboard fallback when Web Share returns AbortError, and runs the associated dependency-free Node test from the local release gate. Complete full-checkout test/build and mobile interaction QA remain UNVERIFIED.
  • Latest PR41 review had no reviews, statuses, or comments; no Actions were invoked. Still Draft / NO-GO.

2026-11-07 — Web Share cancellation and route-state follow-up

  • Fixed native-share cancellation: AbortError no longer triggers an unsolicited clipboard copy. Genuine other share failures retain the copy fallback. Added unit tests and a dependency-free Node regression.
  • ShareBar's result-link state now resynchronizes on url and slug changes (locale/tool navigation); added source regression checks.
  • Executed exact GitHub-source pure helper tests in a local isolated environment: 8/8 passed, covering embed HTML (6) and share cancellation (2). Both helpers passed isolated strict TypeScript checking. Eleven GitHub source wiring checks matched.
  • Public character-frequency page displayed related tools and a Text Batch Studio link; this does not verify the PR41 deployment or the production release SHA.
  • NO-GO remains for complete repository npm install/Vitest/Next build, device/locale/clipboard QA, consent/GA4, review, merge and owner deployment. GitHub Actions were not run.

2026-11-07 all-workflow audit (manual-only)

  • Enumerated the eight .github/workflows/*.yml files on the PR41 branch using GitHub repo contents and evaluated their actual source using the existing verifyManualDeployWorkflow rule: 8/8 manual-dispatch only. ci.yml and toolify-live-index.yml were concurrently changed to remove push/PR auto-runs.
  • Fixed the existing full-directory verifier's escaped file-extension regex and directory tests' escaped YAML fixture and filename matching. Reconstructed corrected Node v22 source and tested 6/6 policy test groups passed, including CLI exit 4 when any CI workflow has an automatic trigger.
  • Removed a concurrently introduced duplicate workflow checker to keep a single release policy implementation; scripts/check-postmerge-embed-release.sh runs verify-manual-deploy.mjs on the entire workflow directory.
  • Source-only verification and isolated Node tests are not full repo Vitest/Next build; PR41 stays Draft / NO-GO. GitHub Actions were not run; merge/deploy must await full owner checkout QA.

2026-11-07 — All workflows, not just deploy.yml

  • Found automatic triggers in two additional workflow files: ci.yml and toolify-live-index.yml, each using push and pull_request. Both were changed on this draft PR branch only to workflow_dispatch: {}; existing jobs remain intact.
  • The fail-closed validator and release gate now inspect the entire 8-file .github/workflows directory. Added regression cases where deploy.yml is safe but CI still has an automatic trigger, and for .yaml names/empty directories.
  • Executed Node 22 tests on exact SHA-matching GitHub source: 6/6 passed. Fresh GitHub readback of all 8 workflow event blocks: 8/8 manual-only.
  • Existing main workflow behavior has not been changed. The PR remains DRAFT / NO-GO without full npm/typecheck/Vitest/Next build, real device/consent QA and review. No Actions, merge or deploy initiated.

2026-11-07 — VPS deploy lock: fail-closed stale recovery and concurrency

  • Fixed a release-safety issue: ops/deploy-lock.sh previously overwrote lock ownership when stale without an atomic recovery claim. It now refuses automatic stale takeover (exit 3) until the owner confirms the old deployment is no longer running and manually clears the lock.
  • Added metadata write/release failure handling and GNU/BSD mtime fallback. Included offline ops/tests/deploy-lock.test.sh in the PR41 gate (no remote SSH or deployment).
  • Matched both executable Bash files against their GitHub blob SHAs, ran syntax checks, and executed the full local lock regression 11 times (initial plus 10 repeated); all passed, including 12 concurrent acquisitions with exactly one lock winner each time.
  • This changes only the PR41 branch. The stale-lock fail-closed behavior and manual recovery requirement need operator review before merging. Full npm/Vitest/build/device/GA4 tests and production release remain NOT DONE; do not merge yet.

2026-11-07 SEO and VPS-lock regression evidence

  • Corrected hasNoindex to treat robots: none and X-Robots-Tag: none as noindex. Improved live growth smoke to reject query/fragment-tainted canonical/redirect URLs, and to require exact sitemap <loc> URL matches, not path-prefix matches.
  • Ran the exact current GitHub helper and Node test files in a local workspace with matching Git blob hashes: node --test 4/4 passed. A deliberately incorrect assertion in the newly authored sitemap test initially failed; it was corrected and the final exact-source suite passed.
  • Executed the exact ops/deploy-lock.sh and offline test from GitHub (SHA-matched) against local temporary directories: PASS, including stale-lock non-takeover and 12-way exclusivity. This did not contact the VPS.
  • No GitHub Actions, PR merge or deployment. Full npm ci / Vitest / Next production build, device QA and postdeploy smoke remain unverified. See docs/PR40_POSTMERGE_FOLLOWUP_2026-11-07.md.

2026-11-07 widget backlink policy mitigation

  • Reviewed official Google Search spam policies: distributing keyword-rich widget backlinks primarily for ranking can be link spam. Previous source comments specifically promoted dofollow backlinks from embeds.
  • Kept visible tool-title and Toolify365 credit links but qualified both with rel="noopener noreferrer nofollow", changed ShareBar comments, and added Vitest, Node and cross-PR regression assertions.
  • Materialized and executed exact PR Git blobs locally (source SHA 4dcb4ae6f55077f207bbd4751fa670d7b6b1790f, Node test SHA ef5130f8253dffa4bd6d1e67448c7a3464576c30): 7/7 Node 22 tests passed. This is NOT full Next/Vitest/build or proof of improved ranking.
  • PR41 remains Draft/NO-GO pending full checkout test, browser QA and owner deployment. No GitHub Actions run.

2026-11-07 — Growth smoke false-positive fixes (executed)

  • Fixed canonical, robots/noindex and software CTA HTML checks so data-rel, data-name and data-href are not accepted as real HTML attributes; comments and hydration scripts were already excluded.
  • Fixed sitemap URL checks to reject <loc> elements appearing only inside XML comments or CDATA.
  • Added direct regression cases for fake attributes and sitemap entries, preserving existing cases. Fetched the exact changed helper/test blobs back from GitHub, verified their Git hashes, and executed the actual node --test: 5/5 test groups passed, 0 failed. test:smoke-html points to this suite and the PR41 release gate invokes that npm script.
  • This does not prove the full site's npm dependencies, complete Vitest/Next build, browser QA or production deployment; keep DRAFT/NO-GO.

Copy link
Copy Markdown
Owner Author

2026-11-13 release integration note: current main includes brand-isolation safety PR #82 (squash 71636908) which deleted the obsolete cross-business Toolify→FXEA301 and FXEA vhost-setup workflows, removed FXEA Nginx deletion from emergency Toolify restore, and added four source tests to CI+deploy before build. PR #82's native CI run #43426136698 completed success.

This draft PR #41 now compares 96 commits ahead / 39 behind main and changes both .github/workflows/ci.yml and .github/workflows/deploy.yml, overlapping those brand-isolation release gates. Do not merge #41 directly until it is rebased on the new main and the node --test ../scripts/tests/vhost-cross-brand-safety.test.mjs gate is retained in BOTH workflows. Its manual-only deploy changes also conflict with the currently operating automated, serialized VPS deployment; document the release-mode decision and verify the outcome before enabling.

Required: new full CI/build/browser and external-host regression tests; preserve Toolify/FXEA Nginx isolation, live SHA verification, deploy lock and correct HTTPS canonicals. No claim that #41 is deployed.

Copy link
Copy Markdown
Owner Author

2026-11-14 independent user-accuracy fix merged to main: PR #93 e78e3b0e8fdb4f27e133ab7f48d0c0da048b801a corrects Workdays Calculator's 17-language false 'always subtract 2' advice, adds explicit exclusive-boundaries mode with shared URL state, keeps the built-in N-workdays mode discoverable, and adds native math/parity tests to the prebuild gate. Its changed files are site/src/tools/workdays-calculator/..., locale messages for that one tool, site/scripts/workdays-faq-parity.test.mjs, and site/package.json; your PR #41's 21 files have no overlap. Keep #41 draft until complete checkout npm test, npm run typecheck, build, browser/embedded release verification and manual production publish. Do not claim verified active-user lift from source-only merge. No GitHub Actions were run.

Copy link
Copy Markdown
Owner Author

2026-11-14 release follow-up: Toolify PR #94 merged as commit 10856e78b5fbb91f8ae4f85a61ce471e11b6ffdd, adding the read-only site/scripts/check-live-workdays-exclusive.mjs public HTML verifier (EN/JA/ES/AR) and its test; source-merge PR #93 was e78e3b0e8fdb4f27e133ab7f48d0c0da048b801a. These do not edit PR #41's 21 changed files; #41 remains draft. Once full npm test, npm run typecheck, and npm run build pass and manual VPS deployment is complete, run from site/: npm run audit:live-workdays-exclusive to check actual SSR checkbox, translation, FAQ, canonicals, redirects, and EN/JA indexability. The verification has not run against production. HYPD browser audit was attempted for Toolify/Pickly but blocked at the HYPD account plan (plan_denied); no external browser proof is currently available. Do not claim additional active users before GA4 and production checks.

Copy link
Copy Markdown
Owner Author

2026-11-15 growth/SEO follow-up: separate safe production-source content PR #95 merged to main (1138708911a5c188d526461eec3350c4a5909f1b): English Percentage Calculator now includes worked examples of 15% discount, 42/56 grade, 1150→1380 month change; source JSON and numerical calculations verified, four Node content tests added. This does not change the PR #41 release workflow, app build, analytics, or index policy. Public Toolify page is reachable via web reader, but source SHA of running VPS was not verifiable. Keep PR #41 Draft pending full checkout test/build/mobile/web-share and live SHA gates. Connected GSC free recent 2026-11-10–12 returned no actionable Toolify page opportunities; old URL Inspection 50-URL sample had 32 crawled-not-indexed, not a sitewide index rate.

Copy link
Copy Markdown
Owner Author

2026-11-15: Existing Toolify source fixes and isolated content PR #95 are already merged separately. PR #41 remains a 21-file safety/workflow change with no full private repo build, Vitest suite, browsers/17-locale QA or VPS deploy proof; no safe authorization to merge as part of generic 'all fixes' without release gates. Google Search Console recent 2026-11-10–12 returned no Toolify opportunities; 50-URL sampled inspection from app-infra (11/14) showed 1 indexed, 32 crawled-not-indexed but is NOT a whole-site rate. Prioritize QA against exact source SHA and VPS release SHA, then sample-page crawl/index details.

Copy link
Copy Markdown
Owner Author

2026-11-15 follow-up: safely extracted the two isolated changes from this Draft PR and merged them onto current main as PR #97 (ba0cc6914fe69305b70d5caee13a41552dc6df3f). ShareBar now uses validated HTML-safe embed snippets (two visible nofollow credit links; URL scheme, credential and attribute escaping checks) and does NOT interpret a Web Share API AbortError as consent to clipboard copy. Preserved main's current tracked socialShareUrl attribution and result-link UX; did not cherry-pick unrelated workflow/deployment changes. Native Node 22 tests against two Git-blob-matched TS helper files: 8/8 passed; branch integration source checks 12/12, main file readback successful. Full Next build/Vitest/browser UX/VPS production release are STILL UNVERIFIED. Keep #41 Draft pending its 21-file deployment safety gates; avoid duplicating these two changes when reconciling.

Copy link
Copy Markdown
Owner Author

2026-11-15 incremental safe carve-outs from Draft PR #41 now merged into main: PR #97 ba0cc6914fe69305b70d5caee13a41552dc6df3f (HTML-escaped safe widget embeds, qualified nofollow links, Web Share AbortError means no clipboard copy) and PR #98 c8a90368545cf8f63515fe8fe7c29650523eb9b5 (ShareBar result-link re-sync on tool/locale navigation). Both main readbacks verified. Two Git SHA-matched TS helpers were tested under Node 22.16.0 --experimental-strip-types: 8/8 tests pass, and branch ShareBar state/cleanup contracts 12/12 pass. Full Next/Vitest/browser/VPS deployed SHA are still NOT checked. Keep #41 draft for unrelated deploy locks and release governance; avoid reintroducing or overwriting these already-shipped-to-main safe changes.

Copy link
Copy Markdown
Owner Author

2026-11-15 20:56 JST follow-up: safely extracted an additional isolated verification fix from this long-lived Draft PR #41 into current main via PR #99 (merge commit e269c43b9a974f2075ec905cab56c942275cc5df). site/scripts/growth-html-checks.mjs now parses exact HTML name, content, rel, href attributes rather than mistaking data-name, data-rel, data-href for actual crawler directives, canonicals or human-clickable CTAs. Both robots: none and noindex now count as blocked indexing. Preserved main's more recent attributed social-share, international tool search index and iframe policy checks. Extended Node source tests; exact merged helper evaluated under isolated V8 across 15/15 scenarios including fake data-href vs true social destination. GitHub main source/test readbacks verified. Native Node and full Next build, live VPS inspection, production release SHA and GSC recrawl remain unverified, so do not claim search traffic uplift or live repaired SEO. Keep this Draft PR #41 open only for remaining workflow/deploy locks and broad E2E; do not overwrite newer main helpers with the older branch content.

Copy link
Copy Markdown
Owner Author

2026-11-15 follow-up: unrelated, safely isolated index-quality fix merged to main via PR #100 (commit fab8a55bb330b747c1b6ff6b75dc774e1b8fbc3b). /en|ja/pregnancy visually retains all seven sequential calculators, but its ItemList JSON-LD now lists only actual locale-indexable tool URLs using the shared isIndexableIn(locale, tool.slug) policy; menstrual-cycle-calculator, pregnancy-weight-gain-calculator, hcg-calculator were historically noindex yet still advertised in structured ItemList. Auto list counts match, empty ItemList omitted in unsupported locales. Three source regression tests added to prebuild, 13/13 source checks passed. Native Next/Node builds, VPS deployment SHA and GSC index impact remain unverified. Do not merge the older 21-file Draft PR #41 wholesale or replace new main code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant