Repository navigation
Toolify post-merge: safe embeds, share UX and manual-only Actions for all workflows (DRAFT) - #41
appdevelopsk wants to merge 96 commits into
Conversation
…ts/tools/ShareBar.tsx
…s/embed-html.test.ts
…th-integration.test.mjs
…e 22 regression suite
…nd disabled workflows
…eshold validation
… deploy lock PASS
|
2026-11-13 release integration note: current main includes brand-isolation safety PR #82 (squash This draft PR #41 now compares 96 commits ahead / 39 behind main and changes both Required: new full CI/build/browser and external-host regression tests; preserve Toolify/FXEA Nginx isolation, live SHA verification, deploy lock and correct HTTPS canonicals. No claim that #41 is deployed. |
|
2026-11-14 independent user-accuracy fix merged to main: PR #93 |
|
2026-11-14 release follow-up: Toolify PR #94 merged as commit |
|
2026-11-15 growth/SEO follow-up: separate safe production-source content PR #95 merged to main ( |
|
2026-11-15: Existing Toolify source fixes and isolated content PR #95 are already merged separately. PR #41 remains a 21-file safety/workflow change with no full private repo build, Vitest suite, browsers/17-locale QA or VPS deploy proof; no safe authorization to merge as part of generic 'all fixes' without release gates. Google Search Console recent 2026-11-10–12 returned no Toolify opportunities; 50-URL sampled inspection from app-infra (11/14) showed 1 indexed, 32 crawled-not-indexed but is NOT a whole-site rate. Prioritize QA against exact source SHA and VPS release SHA, then sample-page crawl/index details. |
|
2026-11-15 follow-up: safely extracted the two isolated changes from this Draft PR and merged them onto current main as PR #97 ( |
|
2026-11-15 incremental safe carve-outs from Draft PR #41 now merged into main: PR #97 |
|
2026-11-15 20:56 JST follow-up: safely extracted an additional isolated verification fix from this long-lived Draft PR #41 into current main via PR #99 (merge commit |
|
2026-11-15 follow-up: unrelated, safely isolated index-quality fix merged to main via PR #100 (commit |
Status: DRAFT / NO-GO
PR #40 is merged; superseded PR #38 is closed without merge. PR #41 contains post-merge hardening. Do not merge or deploy based on isolated test results. GitHub Actions were not invoked.
Implemented
on: workflow_dispatch), keeping VPS lock and release-SHA checks. Current main retains its preexisting auto-deploy workflow until an authorized merge.scripts/check-postmerge-embed-release.shchecks its exact branch, fetches current origin/main, requires ancestry, and uses the strictscripts/verify-manual-deploy.mjsparser to reject all unreviewed workflow event syntax (includingon: [push], inline event lists/mappings, duplicate events). It then runs four dependency-free verifier regression test groups, six embed Node tests, npm install, smoke/integration, typecheck, Vitest, validation, SEO/i18n/index audits and Next build.Executed evidence (not simulated)
node --test verify-manual-deploy.test.mjs: 4/4 passed, including actual CLI accept (0) and reject (4).bash -n: passed. Actual CLI rejectson: [push]with exit 4.Release blockers
bash scripts/check-postmerge-embed-release.shonfix/toolify-postmerge-embed-safety-20261107, fix any failures, review the workflow trigger change and browser behavior, then approve PR41. Owner performs manual production deploy andSITE_URL=https://toolify365.com npm run audit:live-growth.Full evidence:
docs/PR40_POSTMERGE_FOLLOWUP_2026-11-07.md. No traffic, conversion or revenue uplift claimed.2026-11-07 15:21 JST update: release origin and business validation
NEXT_PUBLIC_SITE_URL=https://toolify365.combeforenpm ci, audits and production build. Without it,siteConfig.urldefaults tohttps://example.pages.dev, risking incorrect canonical, share, iframe, and SEO URLs.isShareCancelled, avoids clipboard fallback when Web Share returnsAbortError, and runs the associated dependency-free Node test from the local release gate. Complete full-checkout test/build and mobile interaction QA remain UNVERIFIED.2026-11-07 — Web Share cancellation and route-state follow-up
AbortErrorno longer triggers an unsolicited clipboard copy. Genuine other share failures retain the copy fallback. Added unit tests and a dependency-free Node regression.urlandslugchanges (locale/tool navigation); added source regression checks.2026-11-07 all-workflow audit (manual-only)
.github/workflows/*.ymlfiles on the PR41 branch using GitHub repo contents and evaluated their actual source using the existingverifyManualDeployWorkflowrule: 8/8 manual-dispatch only.ci.ymlandtoolify-live-index.ymlwere concurrently changed to remove push/PR auto-runs.scripts/check-postmerge-embed-release.shrunsverify-manual-deploy.mjson the entire workflow directory.2026-11-07 — All workflows, not just deploy.yml
ci.ymlandtoolify-live-index.yml, each usingpushandpull_request. Both were changed on this draft PR branch only toworkflow_dispatch: {}; existing jobs remain intact..github/workflowsdirectory. Added regression cases where deploy.yml is safe but CI still has an automatic trigger, and for.yamlnames/empty directories.mainworkflow behavior has not been changed. The PR remains DRAFT / NO-GO without full npm/typecheck/Vitest/Next build, real device/consent QA and review. No Actions, merge or deploy initiated.2026-11-07 — VPS deploy lock: fail-closed stale recovery and concurrency
ops/deploy-lock.shpreviously overwrote lock ownership when stale without an atomic recovery claim. It now refuses automatic stale takeover (exit 3) until the owner confirms the old deployment is no longer running and manually clears the lock.ops/tests/deploy-lock.test.shin the PR41 gate (no remote SSH or deployment).2026-11-07 SEO and VPS-lock regression evidence
hasNoindexto treatrobots: noneandX-Robots-Tag: noneas noindex. Improved live growth smoke to reject query/fragment-tainted canonical/redirect URLs, and to require exact sitemap<loc>URL matches, not path-prefix matches.node --test4/4 passed. A deliberately incorrect assertion in the newly authored sitemap test initially failed; it was corrected and the final exact-source suite passed.ops/deploy-lock.shand offline test from GitHub (SHA-matched) against local temporary directories: PASS, including stale-lock non-takeover and 12-way exclusivity. This did not contact the VPS.npm ci/ Vitest / Next production build, device QA and postdeploy smoke remain unverified. Seedocs/PR40_POSTMERGE_FOLLOWUP_2026-11-07.md.2026-11-07 widget backlink policy mitigation
rel="noopener noreferrer nofollow", changed ShareBar comments, and added Vitest, Node and cross-PR regression assertions.4dcb4ae6f55077f207bbd4751fa670d7b6b1790f, Node test SHAef5130f8253dffa4bd6d1e67448c7a3464576c30): 7/7 Node 22 tests passed. This is NOT full Next/Vitest/build or proof of improved ranking.2026-11-07 — Growth smoke false-positive fixes (executed)
data-rel,data-nameanddata-hrefare not accepted as real HTML attributes; comments and hydration scripts were already excluded.<loc>elements appearing only inside XML comments or CDATA.node --test: 5/5 test groups passed, 0 failed.test:smoke-htmlpoints to this suite and the PR41 release gate invokes that npm script.