Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions scripts/test_sitemap_route_integrity.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def resolve_source(url):
if f"{parsed.scheme}://{parsed.netloc}" != ORIGIN or parsed.query or parsed.fragment:
raise ValueError(f"Unexpected sitemap URL: {url}")
path = unquote(parsed.path)
if ".." in Path(path).parts or "\\\\" in path:
if ".." in Path(path).parts or "\\" in path:
raise ValueError(f"Unsafe sitemap path: {url}")
if path == "/":
return ROOT / "index.html"
Expand All @@ -59,13 +59,9 @@ def test_every_sitemap_route_has_a_real_source(self):
with self.subTest(url=url):
self.assertTrue(resolve_source(url).is_file(), f"missing HTML for {url}")

def test_key_conversion_pages_have_exact_self_canonical(self):
for path in ("/", "/apps", "/support/blur/",
"/support/dog-breeds-encyclopedia/",
"/guides/quick-games/"):
url = ORIGIN + path
def test_all_sitemap_pages_have_exact_self_canonical(self):
for url in listed_urls():
with self.subTest(url=url):
self.assertIn(url, listed_urls())
parser = CanonicalParser()
parser.feed(resolve_source(url).read_text(encoding="utf-8"))
self.assertEqual(parser.values, [url],
Expand Down
Loading