Repository navigation
tests: allow spaces in guide_store_click gtag check - #91
Merged
Merged
Conversation
Guide pages call window.gtag('event', 'guide_store_click', ...) with spaces;
the regex required no spaces, so main had 1 failing test (51/52).
Claude-Session: https://claude.ai/code/session_01J5anYPdQ1D7nCCyssJYJyv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix. main had 1 failing test (guide landing pages): the page code is
window.gtag('event', 'guide_store_click', …)with spaces but the regex required none. After: node --test tests/ 52/52 pass. No site file changes (nothing to deploy).https://claude.ai/code/session_01J5anYPdQ1D7nCCyssJYJyv