Repository navigation
test(release): verify all four editorial guide funnels on deployed HTML - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production verification gap
Existing read-only
scripts/check_growth_live.pychecks the catalog and five priority app pages, but omits the four editorial guides. PR #84 added 17 first-party FAQ links to guides and #85 standardized their store-outbound events; we need the production smoke to detect missing, stale or partially published guide HTML.Change
Add four guide paths to the HTTP smoke with a 17-app allowlisted baseline (growth may add more apps without failing).
Verify an actual canonical link, expected legacy+shared store and detail event names, and each guide card's Google Play button, matching internal support path, app slug and app-specific accessible name. Reject duplicate/incorrect/missing app links, including any new card without a detail link.
Extend valid fixtures and add three negative Python cases: missing Instant Judge detail link, missing AI guide
download_click, and an extra guide card lacking a support link.Verification
Direct source review of scripts/check_growth_live.py and scripts/test_growth_live.py completed: 4 guide routes in PATHS, static smoke checks in place, 37 Python test methods in existing suite.
Reproduced the new guide validation block against representative 17-card guide fixtures: 29/29 positive checks passed, and 4 deliberately broken scenarios (missing detail link, missing event, missing new-card link, wrong support target) correctly failed. These are representative fixtures, not production HTTP results or full 37 Python tests against a fresh checkout.
No GitHub Actions, deployment or claim of GA4 delivery/install growth. Owner can run
python3 scripts/check_growth_live.pyon networked checkout after publishing main.