Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps.html
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ <h2 id="app-spotlight-title" style="font-size:1.1rem;margin-bottom:.4rem">Explor
<a href="/support/instant-judge/" data-detail-app="instant-judge">Instant Judge · Community voting</a>
</nav>
</section>
<p id="finder-empty" class="finder-meta" hidden>No matches. Try another word or choose All apps.</p>
<p id="finder-empty" class="finder-meta" hidden>No matches. <button type="button" id="finder-reset" aria-label="Clear search and show all apps" style="cursor:pointer;color:var(--accent);background:none;border:0;text-decoration:underline;font:inherit;font-weight:600">Clear search and filters</button></p>
<div class="grid">
<a class="app-card" href="https://play.google.com/store/apps/details?id=jp.appdevelopsk.facesymmetry&amp;utm_source=appdevelopsk&amp;utm_medium=web&amp;utm_campaign=apps_catalog&amp;referrer=utm_source%3Dappdevelopsk%26utm_medium%3Dweb%26utm_campaign%3Dapps_catalog" target="_blank" rel="noopener">
<img src="icons/apps/face-symmetry.png" alt="HangTrue - Level Checker icon" loading="lazy" width="64" height="64">
Expand Down Expand Up @@ -1416,6 +1416,7 @@ <h3>Chaos - Stranger Missions</h3>
const buttons = Array.from(document.querySelectorAll('.finder-filters button'));
const count = document.getElementById('finder-count');
const empty = document.getElementById('finder-empty');
const reset = document.getElementById('finder-reset');
const groups = {
'quick-games': ['blur','instant-judge','twotaku','nodo','brain-burst','snap-judge','daily-duel','percent-pulse','two-truths','key-clash','tier-rank-me'],
habits: ['true-me','future-me','water-reminder','gratitude-log','gratitude-challenge','mood-log','sleep-prep','eye-break','stretch-reminder','win-log'],
Expand Down Expand Up @@ -1455,6 +1456,15 @@ <h3>Chaos - Stranger Missions</h3>
}
if (!input.value.trim()) loggedSearch = false;
});
reset.addEventListener('click', () => {
input.value = '';
goal = 'all';
loggedSearch = false;
buttons.forEach(button => button.setAttribute('aria-pressed', String(button.dataset.goal === 'all')));
render();
input.focus();
fire('catalog_search_reset', {source: 'empty_state'});
});
buttons.forEach(button => button.addEventListener('click', () => {
goal = button.dataset.goal;
buttons.forEach(b => b.setAttribute('aria-pressed', String(b === button)));
Expand Down
7 changes: 7 additions & 0 deletions scripts/check_growth_live.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ def check(path, key, valid):
check("/apps", "no_stale_live_store_claim", "92 free apps on Google Play" not in catalog)
check("/apps", "store_click_tracking", "catalog_store_click" in catalog and "download_click" in catalog)
check("/apps", "detail_click_tracking", "catalog_app_detail_click" in catalog)
check("/apps", "empty_search_reset",
'id="finder-reset"' in catalog and
"reset.addEventListener('click'" in catalog and
"input.value = ''" in catalog and
"goal = 'all'" in catalog and
"render();" in catalog and
"catalog_search_reset" in catalog)
details = re.findall(
r'<a\b[^>]*\bhref="([^"]+)"[^>]*\bdata-detail-app="([^"]+)"', catalog
)
Expand Down
11 changes: 11 additions & 0 deletions scripts/test_growth_live.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def valid_pages():
pages["/apps"] = (
'<script type="application/ld+json">' + json.dumps(listing) + '</script>' +
cards + " catalog_store_click download_click catalog_app_detail_click " +
'id="finder-reset" reset.addEventListener(\'click\' input.value = \'\' goal = \'all\' render(); catalog_search_reset ' +
" ".join(f'<a href="/support/{slug}/" data-detail-app="{slug}">' for slug in SLUGS)
)
related = {"debate-me": ("future-me", "tappitsu-battle"),
Expand Down Expand Up @@ -185,6 +186,16 @@ def test_store_schema_package_mismatch_fails(self):
"id=jp.appdevelopsk.testapp1", "id=jp.appdevelopsk.unlisted", 1)
self.assertFalse(inspect(data)["passed"])

def test_missing_empty_search_reset_fails(self):
data = valid_pages()
data["/apps"] = data["/apps"].replace('id="finder-reset"', 'id="missing-reset"')
self.assertFalse(inspect(data)["passed"])

def test_broken_empty_search_reset_handler_fails(self):
data = valid_pages()
data["/apps"] = data["/apps"].replace("goal = 'all'", "goal = 'habits'")
self.assertFalse(inspect(data)["passed"])

def test_stale_catalog_claim_fails(self):
data = valid_pages()
data["/apps"] += "92 free apps on Google Play"
Expand Down
Loading