Skip to content

fix(analytics): track homepage app-card clicks as navigation, not app views - #63

Merged
appdevelopsk merged 3 commits into
mainfrom
fix/home-card-click-event-20261106
Nov 6, 2026
Merged

appdevelopsk merged 3 commits into
mainfrom
fix/home-card-click-event-20261106

Conversation

@appdevelopsk

Copy link
Copy Markdown
Owner

Fixes misleading acquisition measurement: homepage cards previously emitted GA4 app_view merely on click. That can overstate actual page views and makes attribution ambiguous. Changes the event to app_detail_click with non-PII app_slug and placement=homepage_card; real GA4 page_view remains the measure of page loads. Adds live smoke validation and 2 regression tests (20 total) to reject the incorrect legacy event or a missing replacement. 20/20 unittest tests executed locally against exact GitHub blob content, hashes 4c5b6db510bd54025a1628a3b418796e6dd314dc and a28fb4b215817adbf8aff968058c1c24b1b2fef5. This is an intentional event schema change: compare metrics by event name and do not aggregate historical app_view clicks with page_view. No GitHub Actions, no production deployment or reported install uplift.

@appdevelopsk
appdevelopsk marked this pull request as ready for review November 6, 2026 00:23
@appdevelopsk
appdevelopsk merged commit 3611409 into main Nov 6, 2026
1 check failed
appdevelopsk added a commit that referenced this pull request Nov 7, 2026
… and unit gates

The deployed pages were correct but the gates still pinned old values:
- check_growth_live: #77 input handler (clears dedupe key, never reports per keystroke)
- check_app_discovery_live: #78 Debate Me title, #53 robots Allow: /icons/
- catalog-growth: #71 ?goal= landing needs URL/location/history/reset in sandbox; #63 app_detail_click
- debate-me / dotchi: current title; sitemap lastmod must not regress (not equal a fixed date)

python 72/72, node tests 52/52 (was 47/52 on main), live 92/92.

Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV
appdevelopsk added a commit that referenced this pull request Nov 7, 2026
…78/#79 (#83)

* fix(deploy): publish TaleTime and Dog Breeds support pages updated in #78/#79

sitemap.xml (#81) advertises lastmod 2026-11-07 for both pages, but
publish_app_discovery.sh did not list them, so --apply would ship the
new sitemap while leaving their old HTML live.

Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV

* test(release): follow intentional #53/#63/#71/#77/#78 changes in live and unit gates

The deployed pages were correct but the gates still pinned old values:
- check_growth_live: #77 input handler (clears dedupe key, never reports per keystroke)
- check_app_discovery_live: #78 Debate Me title, #53 robots Allow: /icons/
- catalog-growth: #71 ?goal= landing needs URL/location/history/reset in sandbox; #63 app_detail_click
- debate-me / dotchi: current title; sitemap lastmod must not regress (not equal a fixed date)

python 72/72, node tests 52/52 (was 47/52 on main), live 92/92.

Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant