Repository navigation
fix(analytics): track homepage app-card clicks as navigation, not app views - #63
Merged
Merged
Conversation
appdevelopsk
marked this pull request as ready for review
November 6, 2026 00:23
7 tasks
appdevelopsk
added a commit
that referenced
this pull request
Nov 7, 2026
… and unit gates The deployed pages were correct but the gates still pinned old values: - check_growth_live: #77 input handler (clears dedupe key, never reports per keystroke) - check_app_discovery_live: #78 Debate Me title, #53 robots Allow: /icons/ - catalog-growth: #71 ?goal= landing needs URL/location/history/reset in sandbox; #63 app_detail_click - debate-me / dotchi: current title; sitemap lastmod must not regress (not equal a fixed date) python 72/72, node tests 52/52 (was 47/52 on main), live 92/92. Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV
appdevelopsk
added a commit
that referenced
this pull request
Nov 7, 2026
…78/#79 (#83) * fix(deploy): publish TaleTime and Dog Breeds support pages updated in #78/#79 sitemap.xml (#81) advertises lastmod 2026-11-07 for both pages, but publish_app_discovery.sh did not list them, so --apply would ship the new sitemap while leaving their old HTML live. Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV * test(release): follow intentional #53/#63/#71/#77/#78 changes in live and unit gates The deployed pages were correct but the gates still pinned old values: - check_growth_live: #77 input handler (clears dedupe key, never reports per keystroke) - check_app_discovery_live: #78 Debate Me title, #53 robots Allow: /icons/ - catalog-growth: #71 ?goal= landing needs URL/location/history/reset in sandbox; #63 app_detail_click - debate-me / dotchi: current title; sitemap lastmod must not regress (not equal a fixed date) python 72/72, node tests 52/52 (was 47/52 on main), live 92/92. Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes misleading acquisition measurement: homepage cards previously emitted GA4
app_viewmerely on click. That can overstate actual page views and makes attribution ambiguous. Changes the event toapp_detail_clickwith non-PIIapp_slugandplacement=homepage_card; real GA4page_viewremains the measure of page loads. Adds live smoke validation and 2 regression tests (20 total) to reject the incorrect legacy event or a missing replacement. 20/20 unittest tests executed locally against exact GitHub blob content, hashes4c5b6db510bd54025a1628a3b418796e6dd314dcanda28fb4b215817adbf8aff968058c1c24b1b2fef5. This is an intentional event schema change: compare metrics by event name and do not aggregate historical app_view clicks with page_view. No GitHub Actions, no production deployment or reported install uplift.