Repository navigation
Release gate: prove app-share script and 3 app landing buttons are publicly deployed - #135
Merged
Merged
Conversation
…ide-effects probe
…le write commands
…ibuting it to literal grep parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Merged reader-initiated sharing (#133) is in source and VPS release manifest, but the existing read-only
scripts/check_app_discovery_live.shdidn't fetch the actual/scripts/app-share.jsor validate the three HTML bindings. An owner release could wrongly be considered complete while share UI was absent or a fallback page was returned at the JS path.Changes
tests/app-support-share.test.mjswith a static contract that keeps the live smoke proof, 3 links and no network-writing commands.Verification
node --test tests/app-support-share.test.mjsand existing app discovery/source smoke checks.bash -n scripts/check_app_discovery_live.shandpython3 scripts/preflight_app_discovery.py.scripts/publish_app_discovery.sh --apply, then separately runscripts/check_app_discovery_live.shand browser sharing tests. The ability to fetch public JS or landing pages through a web search tool is not conclusive HTTP status evidence.No VPS credentials accessed, --apply run, real share/installed user count claimed, ad spend or app-store release.