Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-appsite-release-bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
assert len(archives) == 1, 'one ZIP per verified source checkout'
with ZipFile(archives[0]) as z:
names = z.namelist()
assert len(names) == 46, f'44 site documents + hash manifest + instructions; got {len(names)}'
assert len(names) == 48, f'46 site documents + hash manifest + instructions; got {len(names)}'
assert z.testzip() is None
assert all(n.startswith('site/') or n in ('SHA256SUMS.txt', 'DEPLOY_README.txt') for n in names)
PY
Expand Down
9 changes: 5 additions & 4 deletions scripts/build_site_release_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
https://appdevelopsk.com and the expected canonical/hreflang, then
check the public app catalog and support landing metadata.

This includes 27 app-discovery documents and 17 approved policy documents
This includes 29 app-discovery documents and 17 approved policy documents
from current source. It is NOT a complete VPS backup, nginx configuration,
database migration, browser test, app-store release, or SEO indexing proof.
"""
Expand All @@ -81,12 +81,13 @@ def release_manifest(root=ROOT):
scripts = root / "scripts"
apps = shell_array((scripts / "publish_app_discovery.sh").read_text(encoding="utf-8"), "files")
policies = shell_array((scripts / "publish_stale_policy_pages.sh").read_text(encoding="utf-8"), "slugs")
if len(apps) != 27 or len(policies) != 17:
if len(apps) != 29 or len(policies) != 17:
raise ValueError("publisher manifest count changed; review before bundling")
if not PRESS.issubset(set(apps)):
raise ValueError("one or more of the five press routes are not in publisher manifest")
if not {"index.html", "apps.html", "sitemap.xml", "robots.txt",
"support/brain-burst/index.html", "support/debate-me/index.html"}.issubset(apps):
"support/brain-burst/index.html", "support/debate-me/index.html",
"guides/ai-debate-practice/index.html", "guides/ai-debate-practice/ja/index.html"}.issubset(apps):
raise ValueError("critical app discovery/SEO pages missing from publisher manifest")
if any(not re.fullmatch(r"[a-z0-9-]+", slug) for slug in policies):
raise ValueError("unsafe privacy-policy slug")
Expand Down Expand Up @@ -147,7 +148,7 @@ def main():
"status": "source_bundle_created_not_deployed",
"output": str(output),
"sha256": digest,
"appDiscoveryFiles": 27,
"appDiscoveryFiles": 29,
"policyFiles": 17,
"totalFiles": len(files),
"pressRoutes": sorted(PRESS),
Expand Down
12 changes: 12 additions & 0 deletions scripts/check_app_discovery_live.sh
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,18 @@ grep -Fq 'support_future_me_hero' "$tmp/futureme.html" || { echo 'FAIL FutureMe
if grep -Eiq 'Letters to future self|Time capsule feature|FutureMe Premium.*[0-9]+/(month|year)|FutureMe Premium 提供月度|NT\\$150/月' "$tmp/futureme.html"; then
echo 'FAIL FutureMe support page contains outdated feature or pricing claims' >&2; exit 1
fi
# Newly indexed bilingual AI debate practice articles must be live and
# point to real Android app destinations, not just appear in sitemap/source.
fetch '/guides/ai-debate-practice/' 'ai-debate-practice.html'
grep -Fq '<html lang="en">' "$tmp/ai-debate-practice.html" || { echo 'FAIL English debate guide language is stale' >&2; exit 1; }
grep -Fq '<title>How to Practice Debating with AI: 3 Exercises | SK Apps</title>' "$tmp/ai-debate-practice.html" || { echo 'FAIL English debate guide source not deployed' >&2; exit 1; }
grep -Fq '<link rel="canonical" href="https://appdevelopsk.com/guides/ai-debate-practice/">' "$tmp/ai-debate-practice.html" || { echo 'FAIL English debate guide canonical missing' >&2; exit 1; }
grep -Fq 'utm_campaign=ai_debate_practice' "$tmp/ai-debate-practice.html" || { echo 'FAIL English debate guide Android referral CTA missing' >&2; exit 1; }
fetch '/guides/ai-debate-practice/ja/' 'ai-debate-practice-ja.html'
grep -Fq '<html lang="ja">' "$tmp/ai-debate-practice-ja.html" || { echo 'FAIL Japanese debate guide language is stale' >&2; exit 1; }
grep -Fq '<title>AIでディベートを練習する方法|3つのテーマと反論のコツ | SK Apps</title>' "$tmp/ai-debate-practice-ja.html" || { echo 'FAIL Japanese debate guide source not deployed' >&2; exit 1; }
grep -Fq '<link rel="canonical" href="https://appdevelopsk.com/guides/ai-debate-practice/ja/">' "$tmp/ai-debate-practice-ja.html" || { echo 'FAIL Japanese debate guide canonical missing' >&2; exit 1; }
grep -Fq 'utm_campaign=ai_debate_practice_ja' "$tmp/ai-debate-practice-ja.html" || { echo 'FAIL Japanese debate guide Android referral CTA missing' >&2; exit 1; }
fetch '/robots.txt' 'robots.txt'
# #53 broadened the allow to /icons/ (covers /icons/apps/).
grep -Eq '^Allow: /icons/(apps/)?$' "$tmp/robots.txt" || { echo 'FAIL Google image crawl allow not live' >&2; exit 1; }
Expand Down
2 changes: 1 addition & 1 deletion scripts/publish_app_discovery.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ root="${APP_SITE_DEPLOY_ROOT:-/var/www/html}"
if [[ ! "$host" =~ ^[a-zA-Z0-9_.@-]+$ || ! "$root" =~ ^/var/www/[a-zA-Z0-9_./-]+$ ]]; then
echo 'Invalid APP_SITE_DEPLOY_HOST or APP_SITE_DEPLOY_ROOT' >&2; exit 2
fi
files=(index.html apps.html sitemap.xml robots.txt guides/quick-games/index.html guides/quick-games/ja/index.html guides/daily-habits/index.html guides/decision-helpers/index.html guides/ai-tools/index.html support/brain-burst/index.html support/snaplingo/index.html support/face-reaction-battle/index.html support/twotaku/index.html support/debate-me/index.html support/idea-market/index.html support/blur/index.html support/instant-judge/index.html support/roast-me/index.html support/future-me/index.html support/tappitsu-battle/index.html support/taletime/index.html support/dog-breeds-encyclopedia/index.html press/index.html press/es/index.html press/pt-br/index.html press/ja/index.html press/id/index.html)
files=(index.html apps.html sitemap.xml robots.txt guides/quick-games/index.html guides/quick-games/ja/index.html guides/daily-habits/index.html guides/decision-helpers/index.html guides/ai-tools/index.html guides/ai-debate-practice/index.html guides/ai-debate-practice/ja/index.html support/brain-burst/index.html support/snaplingo/index.html support/face-reaction-battle/index.html support/twotaku/index.html support/debate-me/index.html support/idea-market/index.html support/blur/index.html support/instant-judge/index.html support/roast-me/index.html support/future-me/index.html support/tappitsu-battle/index.html support/taletime/index.html support/dog-breeds-encyclopedia/index.html press/index.html press/es/index.html press/pt-br/index.html press/ja/index.html press/id/index.html)
for file in "${files[@]}"; do
[[ -s "$file" ]] || { echo "Missing source file: $file" >&2; exit 2; }
done
Expand Down
4 changes: 4 additions & 0 deletions scripts/test_live_smoke_source_parity.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
"apps.html": "apps.html",
"quick-games.html": "guides/quick-games/index.html",
"quick-games-ja.html": "guides/quick-games/ja/index.html",
"ai-debate-practice.html": "guides/ai-debate-practice/index.html",
"ai-debate-practice-ja.html": "guides/ai-debate-practice/ja/index.html",
"sitemap.xml": "sitemap.xml",
"brain-burst.html": "support/brain-burst/index.html",
"taletime.html": "support/taletime/index.html",
Expand Down Expand Up @@ -92,6 +94,8 @@ def test_expected_app_pages_are_actually_represented(self):
self.assertIn("taletime.html", report["files"])
self.assertIn("futureme.html", report["files"])
self.assertIn("sitemap.xml", report["files"])
self.assertIn("ai-debate-practice.html", report["files"])
self.assertIn("ai-debate-practice-ja.html", report["files"])

def test_missing_required_marker_is_detected(self):
fake = """grep -Fq 'current title' "$tmp/debate-me.html" || exit 1"""
Expand Down
21 changes: 21 additions & 0 deletions scripts/test_publish_app_discovery_staging.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import tempfile
import unittest
from pathlib import Path, PurePosixPath
from urllib.parse import urlsplit
from xml.etree import ElementTree

ROOT = Path(__file__).resolve().parents[1]
PUBLISH = ROOT / "scripts" / "publish_app_discovery.sh"
Expand Down Expand Up @@ -52,11 +54,30 @@ def rsync_to(directory, paths, dry_run=False):


class AppPublishStagingTests(unittest.TestCase):
def test_every_sitemapped_growth_guide_is_in_publisher_manifest(self):
# A newly written/indexed guide must not be absent from the VPS
# release manifest (Nov 14: two AI debate guides were initially omitted).
source = ElementTree.parse(ROOT / "sitemap.xml").getroot()
expected = set()
for node in source.iter():
if node.tag.rsplit("}", 1)[-1] != "loc" or not node.text:
continue
url = urlsplit(node.text.strip())
if url.scheme == "https" and url.netloc == "appdevelopsk.com":
if url.path.startswith("/guides/"):
self.assertTrue(url.path.endswith("/"), url.path)
expected.add(url.path.lstrip("/") + "index.html")
self.assertGreaterEqual(len(expected), 7)
missing = expected - set(manifest())
self.assertFalse(missing, "Public sitemap advertises guides not in the VPS rsync manifest: " + ", ".join(sorted(missing)))

def test_real_relative_rsync_layout_matches_exact_allowlist(self):
paths = manifest()
self.assertTrue(PRESS.issubset(set(paths)), "Every press locale must deploy")
self.assertIn("apps.html", paths)
self.assertIn("support/brain-burst/index.html", paths)
self.assertIn("guides/ai-debate-practice/index.html", paths)
self.assertIn("guides/ai-debate-practice/ja/index.html", paths)
with tempfile.TemporaryDirectory() as tmp:
dest = Path(tmp) / "www"
dest.mkdir()
Expand Down
6 changes: 5 additions & 1 deletion scripts/test_site_release_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@
class AppsiteReleaseBundleTests(unittest.TestCase):
def test_exact_publish_manifest_has_five_press_and_seventeen_policies(self):
files = bundle.release_manifest()
self.assertEqual(len(files), 44)
self.assertEqual(len(files), 46)
self.assertEqual(len(files), len(set(files)))
self.assertTrue(bundle.PRESS.issubset(files))
for guide in ("guides/ai-debate-practice/index.html",
"guides/ai-debate-practice/ja/index.html"):
self.assertIn(guide, files, "published sitemap entry missing from release ZIP")

self.assertEqual(sum(x.startswith("privacy-policy/") for x in files), 17)
self.assertNotIn(".env", "\n".join(files))
self.assertFalse(any(".." in Path(x).parts or "." in Path(x).parts for x in files))
Expand Down
Loading