Repository navigation
CI: prevent app-site release smoke from rejecting correctly deployed source - #124
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Real VPS smoke failure has identified 5 missing international press routes and stale app landings. Previous PR #122 corrected two source/smoke mismatches that were discovered only when dormant tests were added. Even after the owner transfers verified main, a new stale assertion in
scripts/check_app_discovery_live.shwould trigger a false rollout failure.Change
grep -Fqconditions against the corresponding currently checked-in HTML/XML source files (15 source routes).if grep -Fqold content assertions as forbidden, not required; unknown static file mappings fail closed. Skip dynamic$slugand$codevariables for the existing localized press tests rather than inaccurately guessing shell expansion.Verified initial evidence
A read-only GitHub fetch/source scan found 58 statically mappable -Fq assertions, of which 57 are positive assertions present in main and one deliberately forbids the outdated Face Reaction Battle homepage link. None were inconsistent. Native PR CI is required to confirm full test pass.
Release caveat
This validates source coherence only. It does not perform a production HTTP request, VPS transfer, social post, indexing submission or user measurement. Owner-only
publish to VPSstill needs explicit apply; independent live smoke must remain failing until actual public HTML matches source. Existing verified owner ZIP from #123 is unaffected.