fix: apply default actor timeout to runs - #134
Merged
Merged
Conversation
ruocco-l
requested changes
Sep 14, 2026
ruocco-l
left a comment
ruocco-l
left a comment
Contributor
There was a problem hiding this comment.
This would work in most cases (when you let it default with the timeouts), but it kinda breaks when you apply some of them, see the comments 🙏
ruocco-l
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was checking some run and noticed that it didn't have any timeout in our tests... So I investigated and found out we were not applying any run timeout to runs in the end.
I've already made a "fix" for this in the past, but it didn't work, because I incorrectly assumed that
DEFAULT_TEST_ACTOR_OPTIONSare actually for the actor (they were not 😭).Tested this change locally, and it actually works and applies the timeout this time 🙏
I've also decided to make the run timeout be one minute less than the actual test timeout, because when the entire test times out, you get messy logs without the run link - so you cannot even match the actor run otherwise...