Repository navigation
feat: add chunkSize to the listRequests() and listKeys() iterators - #1142
Merged
Merged
Conversation
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/38231762271#summary-114752688089 |
barjin
approved these changes
Oct 12, 2026
barjin
left a comment
Member
There was a problem hiding this comment.
lgtm, just one docs nit ⬇️
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestQueue.listRequests()andkeyValueStore.listKeys()take achunkSizeoption, like the other paginated iterators. Each page asks for at mostchunkSizeitems, or for what's left oflimitif that's smaller.chunkSizeis never sent to the API and has no default, so existing calls send the same requests.minForLimitParammoved tosrc/utils.tsso both iterators can share it.createKeysPublicUrl()builds a URL and doesn't page, so its options type leaveschunkSizeout.One small side effect: an explicit
limit: 0is now left out of the first request, as the offset-paginatedlist()methods already do. The API reads 0 as unset.Closes: #1130
Closes: #1131
✍️ Drafted by Claude Code