Repository navigation
Conversation
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/37437325785#summary-112182231331 |
vdusek
marked this pull request as ready for review
October 6, 2026 08:54
Contributor
Author
|
Closing: per Pijukatel's review on the Python twin, we're not adding the public ✍️ Drafted by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the live paging behind
RunClient.iterateDatasetItems()(#1085) into a newDatasetClient.iterateItems(). WithoutstopCondition, it iterates likelistItems(). With it, the iterator follows a dataset that is still being written to:stopConditionis called before each poll, resolves to whether the writer has finished, and paces the polls. It can't be combined withdesc.iterateDatasetItems()keeps its options and sends the same requests. It now only pins the run on alastRun()client and passes a callback that long-pollswaitForFinish(). The dataset client does the paging: pages end atitemCount, the rows past the laggingitemCountare read once the run finishes, and alimit=1read checks a page that filters emptied.This follows Pijukatel's review on the Python twin, apify/apify-client-python#1079, which got the same change in apify/apify-client-python@fbf4192. It keeps the dataset paging in the dataset client and leaves only the end condition in the run client.
✍️ Drafted by Claude Code